Skip to content

Draft: Convert trial during signup form to Vue

Doug Stull requested to merge 348252-improve-saas-trial-form-by-updating-required-fields-add-state-2 into master

What does this MR do and why?

  • Converts haml form to Vue
  • changes from grid system to flex as it matches the ee/app/assets/javascripts/hand_raise_leads/hand_raise_lead/components/hand_raise_lead_button.vue for maintainability.
  • Conversion done so that the next step we can add the state as per #348252 (closed) where it will need to use javascript to toggle the field visibility, etc for certain countries.

Screenshots or screen recordings

platform before after
desktop Screen_Shot_2022-01-14_at_9.30.41_AM
mobile Screen_Shot_2022-01-14_at_9.33.10_AM
desktop/toggled Screen_Shot_2022-01-07_at_11.20.12_AM
mobile/toggled Screen_Shot_2022-01-07_at_11.20.30_AM

How to set up and validate locally

  1. Sign out.
  2. Register as a new user.
  3. Select My company or team when Who will be using GitLab? question is asked.
  4. Toggle the GitLab Ultimate trial (optional) switch on Group creation form.
  5. Observe form fields for trial.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #348252 (closed)

Edited by Doug Stull

Merge request reports