Fix schema registration in the pipeline editor

changed milestone to %14.7

added devopsverify frontend grouppipeline authoring sectionops typebug labels

1 Warning

This merge request changed undocumented Vue components in vue_shared/. Please consider creating Stories for these components:

app/assets/javascripts/vue_shared/components/source_editor.vue

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Robert Hunt (`@rob.hunt`) (UTC+0, 8 hours behind `@mgandres`)	Nicolò Maria Mezzopera (`@nmezzopera`) (UTC+1, 7 hours behind `@mgandres`)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

marked this merge request as ready

added 1 commit

e9a6fead - Emit event when source editor is mounted

Compare with previous version

mentioned in issue #347101 (closed)

added 1 commit

292102f4 - Emit event when source editor is mounted

Compare with previous version

Hi @dmishunov! I'm not well-versed in editor knowledge, but I've created a fix here to address the issue where the pipeline editor fails to register the CI schema and I'd like someone from ~"group::editor" to review this first to see if it's okay. Could you take a look at this MR?

requested review from @dmishunov

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 6c79b619 and 1d223d65

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.66 MB	3.66 MB	-	0.0 %
mainChunk	2.28 MB	2.28 MB	-	0.0 %

Significant Growth: 1

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.projects.security.dast_profiles	1.12 MB	1.16 MB	+34.91 KB	3.0 %

Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

Note: We do not have exact data for 6c79b619. So we have used data from: 082d4c27.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

Allure report

allure-report-publisher generated test report for 1d223d65!

review-qa-reliable: test report
review-qa-smoke: test report

Just a heads up, @mgandres: this takes a bit more time than anticipated. The reason is: I'm not convinced we should be introducing a new event here. I'm taking a closer look at the issue and possible solutions and will get back to you at beginning of the next week. Moreover, there might be an opportunity for a slight improvement of the pipeline editor's architecture that will fix the issue in a more consistent and holistic manner.

added 332 commits

292102f4...737ecf8b - 331 commits from branch master
5b87f1d0 - Fix schema registration in the pipeline editor

Compare with previous version

changed title from Emit event when source editor is mounted to Fix schema registration in the pipeline editor

changed the description

@nadia_sotnikova this should fix the bug with the autocomplete on the pipeline editor, if you want to take a look!

added 412 commits

5b87f1d0...84156e22 - 411 commits from branch master
5cbb90ab - Fix schema registration in the pipeline editor

Compare with previous version

approved this merge request

@mgandres thanks a lot for accepting my suggestion and updating the tests. I have only one non-blocking nitpick for your consideration. Otherwise I'm happy to approve. To make sure we do things transparently and effectively, I would like to ask @f_caplette to maintainerize this MR to make sure it doesn't overlook anything important. Fred, I see you're busy though, so please feel free to re-assign if you won't have time for this