Skip to content

Fix pipeline schedule resets to UTC on edit

Jonston Chan requested to merge forked-repo/gitlab-org/gitlab:JonstonChan-345925-fix-schedule-resets-to-utc into master

What does this MR do and why?

This MR fixes #345925 (closed)

From #345925 (closed):

the behavior seem to be every other time the pipeline gets edited

The form submits the timezone identifier when a new pipeline schedule is created, and the identifier is used the first time the "edit" page is reached.

The timezone dropdown picker replaces the value to the timezone name when the cron picker is loaded. The timezone dropdown picker also changes the value to the timezone identifier when an item has been selected.

Since the timezone dropdown picker replaces the timezone identifier with the timezone name and the initial timezone is found by an identifier, an incorrect timezone is shown after a pipeline schedule edit without choosing a timezone.

Screenshots

No visual changes aside from displaying correct timezone after edit

timezone

How to set up and validate locally

From original issue (#345925 (closed)):

  • Create a pipeline Schedule.
  • Select a different timezone from UTC.
  • Add variables to the schedule.
  • Save.
  • Go edit the schedule pipeline.
  • Timezone now retains saved value.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jonston Chan

Merge request reports