Skip to content
Snippets Groups Projects

Migrate enable Gitpod confirmation modal to `GlModal`

What does this MR do and why?

Related to #344567 (closed)

When viewing a repository tree, file blob, or MR there is an Gitpod button. If the user does not have Gitpod integration enabled yet it will display a modal asking if the user wants to enable the Gitpod integration. Currently this is a Bootstrap modal. This MR migrates that modal to GitLab UI GlModal.

Screenshots or screen recordings

MR

Before After
Screen_Recording_2022-01-10_at_4.10.04_PM Untitled__2_

File blob

Before After
Screen_Recording_2022-01-10_at_4.22.41_PM Untitled__3_

Repository tree

Before After
Screen_Recording_2022-01-10_at_4.23.27_PM Screen_Recording_2022-01-10_at_4.33.30_PM

How to set up and validate locally

  1. Ensure :refactor_blob_viewer feature flag is disabled
    • The refactored blob view does not yet use the Gitpod button
  2. Sign in as an Admin
  3. Navigate to /admin/application_settings/general#js-gitpod-settings and enable Gitpod
  4. Navigate to /-/profile/preferences and ensure Enable Gitpod integration is unchecked
  5. Navigate to a Merge Request and click Open in Gitpod
  6. Navigate to a Repository and click Gitpod from the top toolbar
  7. Navigate to a file in a repository and click Gitpod from the top toolbar

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Setting label(s) ~"Category:Authentication and Authorization" devopsmanage sectiondev based on ~"group::authentication and authorization".

  • added devopsmanage sectiondev + 1 deleted label

  • Peter Hegman added 1 commit

    added 1 commit

    • 5b39929c - Migrate enable Gitpod confirmation modal to `GlModal`

    Compare with previous version

  • mentioned in issue #344567 (closed)

  • Peter Hegman added 1 commit

    added 1 commit

    • a74dd21f - Migrate enable Gitpod confirmation modal to `GlModal`

    Compare with previous version

  • mentioned in issue #344566 (closed)

  • Peter Hegman changed the description

    changed the description

  • Peter Hegman added 345 commits

    added 345 commits

    Compare with previous version

  • Peter Hegman changed milestone to %14.7

    changed milestone to %14.7

  • Please register or sign in to reply
    Loading