Migrate enable Gitpod confirmation modal to `GlModal`
What does this MR do and why?
Related to #344567 (closed)
When viewing a repository tree, file blob, or MR there is an Gitpod
button. If the user does not have Gitpod
integration enabled yet it will display a modal asking if the user wants to enable the Gitpod integration. Currently this is a Bootstrap modal. This MR migrates that modal to GitLab UI GlModal
.
Screenshots or screen recordings
MR
Before | After |
---|---|
Screen_Recording_2022-01-10_at_4.10.04_PM | Untitled__2_ |
File blob
Before | After |
---|---|
Screen_Recording_2022-01-10_at_4.22.41_PM | Untitled__3_ |
Repository tree
Before | After |
---|---|
Screen_Recording_2022-01-10_at_4.23.27_PM | Screen_Recording_2022-01-10_at_4.33.30_PM |
How to set up and validate locally
- Ensure
:refactor_blob_viewer
feature flag is disabled- The refactored blob view does not yet use the
Gitpod
button
- The refactored blob view does not yet use the
- Sign in as an Admin
- Navigate to
/admin/application_settings/general#js-gitpod-settings
and enable Gitpod - Navigate to
/-/profile/preferences
and ensureEnable Gitpod integration
is unchecked - Navigate to a Merge Request and click
Open in Gitpod
- Navigate to a Repository and click
Gitpod
from the top toolbar - Navigate to a file in a repository and click
Gitpod
from the top toolbar
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added frontend pajamasintegrate typemaintenance + 1 deleted label
assigned to @peterhegman
- A deleted user
added backend label
1 Warning This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/web_ide_link.vue
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Vladlena Shumilo ( @vshumilo
) (UTC-5, 3 hours ahead of@peterhegman
)Kerri Miller ( @kerrizor
) (UTC-8, same timezone as@peterhegman
)frontend Justin Ho ( @justin_ho
) (UTC+7, 15 hours ahead of@peterhegman
)Kushal Pandya ( @kushalpandya
) (UTC+5.5, 13.5 hours ahead of@peterhegman
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 2398ecae and d1b9e329
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent mainChunk 2.28 MB 2.28 MB - -0.0 % average 3.65 MB 3.65 MB - -0.0 %
Note: We do not have exact data for 2398ecae. So we have used data from: dfdc2855.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for d1b9e329!review-qa-reliable:
test report
review-qa-smoke: test report @peterhegman, please can you answer the question: Should this have a feature flag? to help with code review for the Access group.This nudge was added by this triage-ops policy.
- Resolved by Ezekiel Kigbo
Setting label(s) ~"Category:Authentication and Authorization" devopsmanage sectiondev based on ~"group::authentication and authorization".
added devopsmanage sectiondev + 1 deleted label
added 1 commit
- 5b39929c - Migrate enable Gitpod confirmation modal to `GlModal`
mentioned in issue #344567 (closed)
added 1 commit
- a74dd21f - Migrate enable Gitpod confirmation modal to `GlModal`
mentioned in issue #344566 (closed)
added 345 commits
-
a74dd21f...645e82d0 - 344 commits from branch
master
- d5509db3 - Migrate enable Gitpod confirmation modal to `GlModal`
-
a74dd21f...645e82d0 - 344 commits from branch
changed milestone to %14.7
- Resolved by Ezekiel Kigbo
@justin_ho can you review this when you have time? If everything looks good can you pass it off to
@ekigbo
(assuming he doesn't have a busy status).