Skip to content

Migrate enable Gitpod confirmation modal to `GlModal`

Peter Hegman requested to merge 344567-migrate-app-views-shared-gitpod-_enable_gitpod_modal-html-haml-modal-implementation-to into master

What does this MR do and why?

Related to #344567 (closed)

When viewing a repository tree, file blob, or MR there is an Gitpod button. If the user does not have Gitpod integration enabled yet it will display a modal asking if the user wants to enable the Gitpod integration. Currently this is a Bootstrap modal. This MR migrates that modal to GitLab UI GlModal.

Screenshots or screen recordings

MR

Before After
Screen_Recording_2022-01-10_at_4.10.04_PM Untitled__2_

File blob

Before After
Screen_Recording_2022-01-10_at_4.22.41_PM Untitled__3_

Repository tree

Before After
Screen_Recording_2022-01-10_at_4.23.27_PM Screen_Recording_2022-01-10_at_4.33.30_PM

How to set up and validate locally

  1. Ensure :refactor_blob_viewer feature flag is disabled
    • The refactored blob view does not yet use the Gitpod button
  2. Sign in as an Admin
  3. Navigate to /admin/application_settings/general#js-gitpod-settings and enable Gitpod
  4. Navigate to /-/profile/preferences and ensure Enable Gitpod integration is unchecked
  5. Navigate to a Merge Request and click Open in Gitpod
  6. Navigate to a Repository and click Gitpod from the top toolbar
  7. Navigate to a file in a repository and click Gitpod from the top toolbar

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports