Skip to content

Fix bulk edit unchecking in issues list refactor

Coung Ngo requested to merge 349628-fix-bulk-edit-in-issues-list-refactor into master

What does this MR do and why?

With the vue_issues_list feature flag enabled (#322755 (closed)), when you select all issues then uncheck one issue, all issues are unchecked which is incorrect behaviour (#349628 (closed)). This MR fixes this so that unchecking the one issue only unselects that one issue.

After selecting all issues, when you uncheck an issue it seems like the input event that's emitted by GlFormCheckbox in issuable_item.vue also triggers GlFormCheckbox in filtered_search_bar_root.vue. Doing @input.stop to stop propagation of the event doesn't work because the event payload isn't an event object but rather a boolean. The solution in this MR is to make these GlFormCheckboxs listen to different event names.

Screenshots or screen recordings

before after
Screen_Recording_2022-01-06_at_2.49.59_pm Screen_Recording_2022-01-06_at_2.50.28_pm

How to set up and validate locally

  1. In rails console enable the FF
    Feature.enable(:vue_issues_list)
  2. Visit any group or project issues page such as http://127.0.0.1:3000/h5bp/html5-boilerplate/-/issues
  3. click on edit Issues
  4. Test the bulk update bug

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #349628 (closed)

Edited by Jannik Lehmann

Merge request reports