Skip to content

Add runner read only admin view

Miguel Rincon requested to merge 347856-read-only-view-runner-feature-flag into master

What does this MR do and why?

This change depends on !77748 (merged) being deployed to workflowproduction.

This change adds a new read only admin view for runners.

The view is empty and behind a feature flag, no user-facing changes done.

Why the rename?

While working on #347856 (closed) and #299758 (closed) I found the naming for our components was no longer correct, so I made a few renames:

from to
~/runner/runner_details/runner_details_app.vue ~/runner/admin_runner_edit/admin_runner_edit_app.vue
#js-runner-details #js-admin-runner-edit
RunnerDetailsApp AdminRunnerEditApp

Screenshots or screen recordings

A new empty page to show runner details is defined at (e.g. http://gdk.test:3000/admin/runners/108) for users that enable runner_read_only_admin_view. This page can be visited from the Runners' Admin page (e.g. http://gdk.test:3000/admin/runners/)

image

Additionally the breadcrumbs of the Edit page have been updated behind runner_read_only_admin_view to match the new URL org. correctly:

from to
image image

How to set up and validate locally

  1. Enable runner_read_only_admin_view
Feature.enable(:runner_read_only_admin_view)
  1. Visit the admin page http://gdk.test:3000/admin/runners

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #347856 (closed)

Edited by Miguel Rincon

Merge request reports