Convert OAuth2 authorization panel to GitLab UI utility classes
requested to merge 344556-migrate-app-views-doorkeeper-authorizations-new-html-haml-modal-implementation-to-glmodal into master
What does this MR do and why?
Related to #344556 (closed)
Removes modal-* CSS classes from OAuth2 authorization panel and replaces them with GitLab UI utility classes.
Screenshots or screen recordings
Desktop
| Before | After |
|---|---|
 |
 |
Mobile
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
Testing the full OAuth2 flow is a bit tricky locally because you need to setup an OAuth2 provider. In this case we don't need to test the full flow since we are just changing the styling of the authorize panel so we can follow the instructions below:
- Login to GitLab as an Admin and navigate to
/admin/applications/new - Fill out the form with the following:
- Name - Foo bar
- Redirect URI - http://foo.bar
- Check
apiunder Scopes
- Navigate to
/oauth/authorize?access_type=online&client_id=<Application ID>&redirect_uri=http%3A%2F%2Ffoo.bar&response_type=code&scope=api. Make sure you update<Application ID>to the Application ID provided in the previous step
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Peter Hegman