Skip to content

Prevent design discussions without user login

Kushal Pandya requested to merge 267570-prevent-design-comments-without-signing-in into master

What does this MR do and why?

This MR fixes the Design Discussions UX where user could attempt to add comments from UI without being logged in and API request would fail, instead, we now show proper banner on UI which asks user to Register or Sign-in before leaving a comment.

Steps to test the MR

  • Checkout to the MR branch locally within GDK
  • Open any existing issue within a public project
  • Upload a couple of images within designs section
  • You should be able to add comments to designs while you're logged-in
  • Visit the same issue while you're not logged-in
  • You should see the message to Register/sign in on UI like shown in the screenshots

Screenshots or screen recordings

New Discussion Reply to Resolved Discussion Reply to Unresolved Discussion
Untitled Untitled Untitled

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #267570 (closed)

Edited by Kushal Pandya

Merge request reports