Skip to content

Global Search - Fix Search Placeholder

Zack Cuddy requested to merge 345745_07-search-placeholder into master

What does this MR do and why?

This addresses a regression found in Production where the Feature Flag unintentionally reverted the Header Search Placeholder text changed as part of !64146 (merged)
Work towards #297396 (closed)

This change is behind a feature flag (:new_header_search)
Feature Flag Rollout Issue: #339348 (closed)

The intended Placeholder text is Search GitLab. However, under the now active feature flag in Production the placeholder text has been changed to the old Search or jump too.... This change fixes that.

Screenshots or screen recordings

Before After
Screen_Shot_2022-01-04_at_2.54.57_PM Screen_Shot_2022-01-04_at_2.54.14_PM

How to set up and validate locally

  1. Fetch and checkout this branch
  2. Add Feature Flag
  3. Go to your GDK home page (ex. http://127.0.0.1/)
  4. Ensure the placeholder text for the Search in the top right says Search GitLab
  5. Focus the Search Field
  6. Ensure the placeholder still says Search GitLab.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Zack Cuddy

Merge request reports