Skip to content

Move the Runner edit page to an `/edit` path

What does this MR do and why?

This change updates the Runner details pages path to end in /edit. This aligns the Runner edit page with other paths in the application.

Users that visit the runner pages will be redirected to the /edit path, so user bookmarks will continue to work as before.

Before:

After:

Why this change?

Internally, this change acts as the first step to split the show and edit pages for each runner.

By leaving both routes available, we can start adding the new, improved "show" page for the runner behind a feature flag, while maintaining the correct paths thought the change.

Paths note

A new edit_admin_runner_path has become available to replace the original edit page, however admin_runner_path will still be present in the application moving forward.

For this reason, I replaced admin_runner_path where it made sense (e.g. editing a runner). For other actions I kept admin_runner_path.

Screenshots or screen recordings

A small change in the breadcrumbs title:

before after
Screen_Shot_2022-01-04_at_2.42.59_PM Screen_Shot_2022-01-04_at_2.43.15_PM

How to set up and validate locally

  1. With some runners available
  2. Visit the admin runners page (http://gdk.test:3000/admin/runners/)
  3. Click on a runner to visit the details, via both the link and the edit button.
  4. Verify the information is displayed correctly, and that the runners can be edited correctly.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #299758 (closed)

Edited by Miguel Rincon

Merge request reports