Skip to content

Add active sync to security configuration tab

Samantha Ming requested to merge 346596-sync-active-tabs-sec-config into master

What does this MR do and why?

This MR updates the security configuration tabs to use the sync-active-tab-with-query-params prop: https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-tabs-tabs--default

Screenshots or screen recordings

sync-active-tabs

How to set up and validate locally

  1. Navigate to Security & Compliance > Configuration
  • When you click on the tabs, it will add a query param to the address
  • When you copy the link of the tab with the query param, it will navigate to that particular tab item

Follow up

Note, this will be further improved with lazy loading as per > #346596 (comment 792225031). Follow-up issue TBD. Thank you for the improvement suggestion @dpisek 🎉

One more thing I've noticed: I think it might make sense to use the lazy prop on the tabs. At the moment any query within any tab will fire on-load. By using lazy we could make sure that we only load data when the user actually opens the tab.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #346596 (closed)

Edited by Samantha Ming

Merge request reports