Skip to content

Add Attention Request icon to MR List users

Thomas Randolph requested to merge tor/feature/mr-list-attention-requests into master

What does this MR do and why?

For #343327 (closed)

Adds the "attention" icon in the MR list if a request for their attention is currently active.

Screenshots or screen recordings

The orange-colored attention icon is added to the MR List assignees/reviewers, and includes a tooltip.

Icon
icon

The tooltip varies based on the scenario:

Assignee or Reviewer Attention Requested Attention Not Requested
Assignee attn-assignee no-attn-assignee
Reviewer attn-reviewer no-attn-review
Scenario Images
User in assignees & reviewers, user in reviewers Sidebar: image
MR List: multi-attn
User in reviewers only Sidebar: image
MR List: reviewer-list
User in assignees only Sidebar: image
MR List: assignee-list

How to set up and validate locally

  1. Enable the mr_attention_requests Feature Flag
  2. Create an MR
  3. Assign it to or request a review from a user
  4. Click the "Request attention" to the left of their name
  5. Navigate to the list of issues (filtering / searching as necessary to find the MR you created)
  6. Gaze in wonder
  7. (optionally) Hover the icon to see the tooltip

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thomas Randolph

Merge request reports