Skip to content

Stub rate limiting logic in raw_controller_spec

Matthias Käppler requested to merge 345686-fix-raw-controller-flaky-specs into master

What does this MR do and why?

Proposal for fixing flaky specs for raw_controller:

This looks like a unit test, but performs integration testing. The way I look at these tests is that if they collaborate with another unit, we should test both units in isolation and rely on interface contracts. So we can address flakiness by stubbing out the rate limiter instead, relying on it to be tested for correctness elsewhere. This also greatly simplifies the test suite and lets us focus on the actual logic we're testing (fetching/rendering raw files).

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #345686 (closed)

Edited by Matthias Käppler

Merge request reports