Allow copy code button to be focusable
What does this MR do and why?
Allows the copy code button in markdown code blocks to be focusable. Previous if it got focused it would not be visible, with this change when the button gets focused on we display it.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added devopscreate frontend groupcode review typebug labels
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Thomas Randolph ( @thomasrandolph
) (UTC-7, 7 hours behind@iamphill
)Natalia Tepluhina ( @ntepluhina
) (UTC+1, 1 hour ahead of@iamphill
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 370d1db0 and f6366a28
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.6 MB -20.98 KB -0.6 % mainChunk 2.26 MB 2.24 MB -19.65 KB -0.9 % Significant Growth: 3Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.registrations.new 6.59 KB 13.81 KB +7.22 KB 109.5 % pages.sessions.new 139.24 KB 146.44 KB +7.2 KB 5.2 % pages.trial_registrations.new 136.6 KB 143.8 KB +7.2 KB 5.3 % Significant Reduction: 4Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.crm.organizations 896.24 KB 799.59 KB -96.65 KB -10.8 % pages.profiles.personal_access_tokens 237.77 KB 206.84 KB -30.92 KB -13.0 % pages.admin.impersonation_tokens 905.23 KB 874.36 KB -30.87 KB -3.4 % pages.projects.settings.access_tokens 863.33 KB 832.46 KB -30.87 KB -3.6 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Note: We do not have exact data for 370d1db0. So we have used data from: 43149951.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for f6366a28!review-qa-smoke:
test reportadded sectiondev label
requested review from @kushalpandya
changed milestone to %14.6
@kushalpandya
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
mentioned in commit 08030b54
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label