Skip to content

Remove js-close class and use gl-my-5 instead of two css classes

Corinna Gogolok requested to merge refactor_css_classes_on_manual_banners into 346260_render_manual_quarterly_co_term_banner

What does this MR do and why?

This takes care of two refactorings:

  • As per this comment: Remove the close_button_class: 'js-close' from both banners.
  • As per this comment: Replace the usage of gl-mt-5 gl-mb-5 with gl-my-5 for the manual renewal banner.

These changes cause no changes to the UI. And the banner will still be rendered as in the two original merge requests.

The banners are behind a feature flag and therefore do not need a changelog.

How to set up and validate locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports