Skip to content

Draft: URL placeholder for merge/squash commit message templates

Grzegorz Korba requested to merge Wirone/gitlab:348466-url_placeholder_in_merge_commit_template into master

What does this MR do and why?

Fixes #348466 (closed)

ℹ This is my first ever attempt to work with GDK (and Rails in general). I don't know if model should generate URL or maybe only return path while final URL should be generated within CommitMessageGenerator in PLACEHOLDERS - thus Draft. Also I had problems with running rspec locally ("FAILED to connect to gitaly") so I don't know if my test case is working (looks like it should be OK). I want to create MR for feedback 🙂

Screenshots or screen recordings

image image

How to set up and validate locally

  1. Configure merge commit message template in project settings: use %{url} placeholder
  2. Create MR
  3. After expanding merge widget you should see merge commit message with full MR's URL included

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports