Update badges for ci builds to use helper
What does this MR do and why?
Update badges for ci builds to use helper
- update badges at /jobs to use the bages helper
Changelog: changed
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Navigate to a project with builds =>
CI/CD
=>Jobs
- Apply the following patch
diff --git a/app/views/projects/ci/builds/_build.html.haml b/app/views/projects/ci/builds/_build.html.haml
index cf8036733bb..80e2335eced 100644
--- a/app/views/projects/ci/builds/_build.html.haml
+++ b/app/views/projects/ci/builds/_build.html.haml
@@ -48,16 +48,17 @@
= sprite_icon('retry', css_class: 'text-warning')
.label-container
- - if job.tags.any?
+ - unless job.tags.any?
+ = gl_badge_tag 'test', size: :sm
- job.tags.each do |tag|
= gl_badge_tag tag, size: :sm
- - if job.try(:trigger_request)
+ - unless job.try(:trigger_request)
= gl_badge_tag _('triggered'), variant: :info, size: :sm
- - if job.try(:allow_failure) && !job.success?
+ - unless job.try(:allow_failure) && !job.success?
= gl_badge_tag _('allowed to fail'), variant: :warning, size: :sm
- - if job.schedulable?
+ - unless job.schedulable?
= gl_badge_tag s_('DelayedJobs|delayed'), variant: :info, size: :sm
- - elsif job.action?
+ - unless job.action?
= gl_badge_tag _('manual'), variant: :info, size: :sm
- if pipeline_link
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #344347 (closed)
Merge request reports
Activity
added OKR-FY24Q2 auto updated component:badge frontend grouppersonal productivity pajamasintegrate sectiondev typemaintenance + 1 deleted label
assigned to @aturinske
Related to gitlab-com/www-gitlab-com#12630 (closed)
- Resolved by Nadia Sotnikova
@tauriedavis can you give this a UX review? I am worried that the badge tag that got switched from
primary
toinfo
has lost its distinction from the other tags.
requested review from @tauriedavis
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Ammar Alakkad ( @aalakkad
) (UTC+3, 10 hours ahead of@aturinske
)Vitaly Slobodin ( @vitallium
) (UTC+3, 10 hours ahead of@aturinske
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report for 89a1adbe!review-qa-smoke:
test reportrequested review from @nadia_sotnikova and removed review request for @tauriedavis
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
@nadia_sotnikova
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @nadia_sotnikova
@psimyn can you review this? Thanks
requested review from @psimyn
changed milestone to %14.6
added 675 commits
-
548a46ba...b990dc7a - 674 commits from branch
master
- 89a1adbe - Update badges for ci builds to use helper
-
548a46ba...b990dc7a - 674 commits from branch
mentioned in commit a4cb0770
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!474 (merged)
added devopsfoundations label and removed 1 deleted label