Skip to content

Fix Patroni replication check

Ben Prescott_ requested to merge bprescott/docs/20211210-patronicheckfix into master

What does this MR do?

Fixes an error in the Patroni replication check - the newline needs to be interpreted by the shell.

Flagged up by a customer in a support ticket. GitLab team members can read more in the ticket

current

# echo 'select * from pg_stat_wal_receiver\x\g\x \n select * from pg_stat_replication\x\g\x' | gitlab-psql
Expanded display is on.
(0 rows)

Expanded display is off.
invalid command \n

proposed

# echo -e 'select * from pg_stat_wal_receiver\x\g\x \n select * from pg_stat_replication\x\g\x' | gitlab-psql
Expanded display is on.
(0 rows)

Expanded display is off.
Expanded display is on.
-[ RECORD 1 ]----+-------------------------------------
pid              | 468
usesysid         | 16384
usename          | gitlab_replicator
application_name | gitlab-testdbc10-patroni3
client_addr      | 172.18.10.113
client_hostname  | 
client_port      | 34818
backend_start    | 2021-12-10 14:33:40.163164+00
backend_xmin     | 
state            | startup
sent_lsn         | 0/4004AE8
write_lsn        | 0/4004AE8
flush_lsn        | 0/4004B58
replay_lsn       | 0/4004B58
write_lag        | 00:00:00.004764
flush_lag        | 00:00:00.004764
replay_lag       | 00:00:00.004764
sync_priority    | 0
sync_state       | async

Expanded display is off.

Related issues

Author's checklist

If you are only adding documentation, do not add any of the following labels:

  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Review checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.
  • Ensure a release milestone is set.
Edited by Ben Prescott_

Merge request reports