Skip to content

Add the drawer to the compliance report application

Robert Hunt requested to merge 342898-add-a-drawer-to-the-merge-request-violations-compliance-report-application into master

What does this MR do and why?

As part of the work to implement the new compliance report, this MR adds the drawer functionality to the table.

The MR does the following:

  • Adds the drawer to the component
  • Updates the existing compliance dashboard to use the new data format
  • Adds mappers to align the data with the required drawer data format
  • Adds a new row to the table by updating the mock resolver data to make testing easier
  • Updates the table to make it selectable
  • Adds/updates the required tests

Screenshots or screen recordings

Existing dashboard New report
Screen_Recording_2022-01-07_at_12.17.56 Screen_Recording_2022-01-11_at_11.41.52

How to set up and validate locally

Existing dashboard working as before

  1. Make sure the new feature flag is disabled by entering the following in your terminal: echo "Feature.disable(:compliance_violations_report)" | rails c
  2. Visit the existing compliance dashboard on a group: [GDK_HOST]/groups/gitlab-org/-/security/compliance_dashboard
  3. Check that you can click on the dashboard rows, opening and closing the drawer by selecting/unselected a row or picking a different row

New report

  1. Enable the new feature flag in your terminal: echo "Feature.enable(:compliance_violations_report)" | rails c
  2. Visit the existing compliance dashboard on a group: [GDK_HOST]/groups/gitlab-org/-/security/compliance_dashboard
  3. Check that you can click on the table rows, opening and closing the drawer by selecting/unselected a row or picking a different row

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #342898 (closed)

Edited by Robert Hunt

Merge request reports