Move "save settings" code from integration_settings_form.js to Vue component
What does this MR do and why?
This MR is part 4 of of #342121 (closed), an effort to remove app/assets/javascripts/integrations/integration_settings_form.js and move its current responsibilities to Vuex or existing Vue components.
- Part 1: !75484 (merged).
- Part 2: !75838 (merged)
- Part 3: !76291 (merged)
In this MR, we remove the SAVE_INTEGRATION_EVENT from the integration form event hub and related Vuex actions/mutations/state. We move all of the "save integration" functionality to integration_form.vue.
There are no user-facing changes in this MR.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
- Enable and configure the Jira integration for the project. More information.
- Click
save settings. The Test button should be disabled and the Save button should be loading while the request is in-flight. Once done, the page will refresh. - Play around with various states of the form (incomplete form, invalid form, etc.).
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #342121 (closed)
Merge request reports
Activity
changed milestone to %14.6
assigned to @tomquirk
removed needs investigation label
1 Message 
CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelogtrailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: truetrailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Tristan Read ( @tristan.read) (UTC+13, 3 hours ahead of@tomquirk)Illya Klymov ( @xanf) (UTC+2, 8 hours behind@tomquirk)~"group::integrations" (frontend) Justin Ho ( @justin_ho) (UTC+7, 3 hours behind@tomquirk)Maintainer review is optional for ~"group::integrations" (frontend) To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Allure report
allure-report-publishergenerated test report for 4416de25!review-qa-smoke:
mentioned in issue #347506 (closed)
mentioned in issue #342121 (closed)
- Resolved by Illya Klymov
Hey @justin_ho, very happy to send this MR your way
As someone very familiar with this code, would you be able to give this a first-round review? I'll add some demo videos soon, but there shouldn't be any user-facing changes. This MR also targets !76291 (merged) :).
- Last reply by Illya Klymov
added workflowin review label and removed workflowin dev label
requested review from @justin_ho
mentioned in merge request !76291 (merged)
added 622 commits
-
0748fb79...b2755055 - 620 commits from branch
342121-move-remaining-events-to-vue-components - 12ce431b - Move 'save integration' code to Vue
- e4136730 - Remove integration_settings_form.js file
-
0748fb79...b2755055 - 620 commits from branch
removed review request for @justin_ho
marked this merge request as draft from 685987db
added 252 commits
-
685987db...74a38a79 - 249 commits from branch
master - a2023fe2 - Move 'save integration' code to Vue
- ad6db20c - Remove integration_settings_form.js file
- 4416de25 - Address reviewer feedback
Toggle commit list-
685987db...74a38a79 - 249 commits from branch
requested review from @justin_ho
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a898ae32 and 4416de25
Entrypoint / Name Size before Size after Diff Diff in percent average 3.6 MB 3.6 MB - -0.0 % mainChunk 2.24 MB 2.24 MB - 0.0 % 
Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.packages.index 956.51 KB 875.68 KB -80.84 KB -8.5 % pages.projects.packages.packages.index 1.1 MB 1.02 MB -80.04 KB -7.1 %
Note: We do not have exact data for a898ae32. So we have used data from: 3fc52919.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
requested review from @xanf and removed review request for @justin_ho
@justin_ho, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
mentioned in commit 535b7c49
added workflowstaging-canary label and removed workflowin review label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added devopsmanage label and removed 1 deleted label
added groupimport and integrate label and removed groupintegrations [DEPRECATED] label
