Add request specs for security policies mutations
What does this MR do and why?
In this MR we're adding missing specs for recently added security policies mutations.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #337962 (closed)
Merge request reports
Activity
changed milestone to %14.6
assigned to @mparuszewski
1 Warning f1d62e16: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sashi Kumar Kumaresan ( @sashi_kumar
) (UTC+5.5, 4.5 hours ahead of@mparuszewski
)Thong Kuah ( @tkuah
) (UTC+13, 12 hours ahead of@mparuszewski
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved [deprecated] Accepting merge requests label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Thong Kuah
@sashi_kumar, would you mind taking a first look?
requested review from @sashi_kumar
requested review from @tkuah and removed review request for @sashi_kumar
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
Thanks @mparuszewski for this MR !
Sorry for the delay. I have some suggestions above to improve the specs.
removed review request for @tkuah
- Resolved by Thong Kuah
requested review from @tkuah
@tkuah
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 69e8c88e succeeds
mentioned in commit 9ae8bef2
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label