Use normal font weight and border for 'subscribe' button
What does this MR do and why?
This is a suggestion to use the normal font weight for the Subscribe button on the labels overview.
Currently, the Subscribe button is hardly legible on screens with a high resolution because it has a font weight of 200. I don’t know of any other button that uses the font weight of 200, so it makes it more consistent.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Go to a project
- Go to Project Information > Labels
- Create a label if there isn’t at least one
- See the changed Subscribe button(s)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
- Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
- If you haven't, please set up a
DANGER_GITLAB_API_TOKEN
. - You can comment
@gitlab-bot label ~"group::"
to add a group label. - After a few days, feel free to ask
@gitlab-bot help
or ping a Merge Request Coach. - Read more on how to get help.
This message was generated automatically. You're welcome to improve it.
added Community contribution label
added Hackathon label
added 1 commit
- f949aa76 - Use normal font weight for 'Subscribe' button
added UX label
mentioned in issue gitlab-org/quality/triage-reports#5500 (closed)
added devopsplan groupproject management sectiondev labels
requested review from @sunjungp
mentioned in issue KevSlashNull/KevSlashNull#3 (closed)
added frontend label
- Resolved by Enrique Alcántara
@sunjungp
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
Hey @KevSlashNull
Thanks for creating this MR - it's a great improvement also aligning with other page designs. I would need to ask how to proceed the frontend review so please give me some time to ask around the team!- Resolved by Martin Wortschack
@KevSlashNull Thank you for the contribution! It looks like we should be able to remove the class entirely (both from the template and from our CSS). There's only one remaining CSS property which is
width: 105px
and I don't think that it's necessary at all. /cc @sunjungp WDYT?
requested review from @wortschi
assigned to @KevSlashNull
changed milestone to %14.6
added 36 commits
-
f949aa76...db259d5b - 35 commits from branch
gitlab-org:master
- 91261234 - Use normal font weight and border for 'Subscribe' buttons
-
f949aa76...db259d5b - 35 commits from branch
3 Warnings This merge request contains deprecated components. Please consider using Pajamas components instead. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Please add a merge request type to this merge request. Deprecated components
These deprecated components are in the process of being migrated. Please consider using Pajamas components instead.
- has-tooltip
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Coung Ngo ( @cngo
) (UTC+0)Enrique Alcántara ( @ealcantara
) (UTC-4)UX Sunjung Park ( @sunjungp
) (UTC+1)No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved review request for @wortschi
added 2297 commits
-
91261234...f510d9cc - 2296 commits from branch
gitlab-org:master
- 7c6d25e9 - Use normal font weight and border for 'Subscribe' buttons
-
91261234...f510d9cc - 2296 commits from branch
mentioned in issue #349007 (closed)
- Resolved by Enrique Alcántara
@justin_ho Can you please review this Community contribution? Since I was involved here, this could need another pair of eyes.
requested review from @justin_ho
changed milestone to %14.7
- Resolved by Kev
- Resolved by Kev
- Resolved by Kev
- Resolved by Kev
removed review request for @justin_ho
mentioned in issue #349317 (closed)
removed review request for @sunjungp
/cc @hollyreynolds
No need to approve as @sunjungp already has on the UX side just want to make sure you're aware of this change.
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added 1513 commits
-
7c6d25e9...f46953d4 - 1510 commits from branch
gitlab-org:master
- ea3b112d - Use normal font weight and border for 'Subscribe' buttons
- 79a82e7c - Cleanup some of _label partial classes
- 865cb28b - Use gl-button-text for 'Subscribe' button texts
Toggle commit list-
7c6d25e9...f46953d4 - 1510 commits from branch
requested review from @pslaughter
- Resolved by Enrique Alcántara
I am unfortunately needing to take a sick day or two
Feel free to assign to another frontend maintainer
requested review from @ealcantara
removed review request for @pslaughter
enabled an automatic merge when the pipeline for cdaf8717 succeeds
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits d0553fc9 and 865cb28b
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.66 MB 3.65 MB -4.7 KB -0.1 % mainChunk 2.28 MB 2.28 MB - -0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.security.dast_profiles 1.12 MB 1.16 MB +34.91 KB 3.0 % Significant Reduction: 4Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.trials.create_lead 837.08 KB 126.95 KB -710.12 KB -84.8 % pages.trials.new 836.63 KB 129.88 KB -706.75 KB -84.5 % pages.groups.security.compliance_dashboards 1.1 MB 998.08 KB -128.42 KB -11.4 % pages.trials.select 129.22 KB 125.91 KB -3.31 KB -2.6 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 865cb28b!review-qa-smoke:
test report
review-qa-reliable: test report- Resolved by Kev
Hi @KevSlashNull,
We would love to know how you found your code review experience in this merge request! Please leave a
or a on this comment to describe your experience.Once done, please comment
@gitlab-bot feedback
below and feel free to leave any additional feedback you have in the same comment.Thanks for your help!
mentioned in commit c12dfc3f
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!562 (merged)