Skip to content
Snippets Groups Projects

Use normal font weight and border for 'subscribe' button

All threads resolved!

What does this MR do and why?

This is a suggestion to use the normal font weight for the Subscribe button on the labels overview.

Currently, the Subscribe button is hardly legible on screens with a high resolution because it has a font weight of 200. I don’t know of any other button that uses the font weight of 200, so it makes it more consistent.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  1. Go to a project
  2. Go to Project Information > Labels
  3. Create a label if there isn’t at least one
  4. See the changed Subscribe button(s)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Kev

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Justin Ho Tuan Duong
  • Justin Ho Tuan Duong
  • Justin Ho Tuan Duong
  • Justin Ho Tuan Duong removed review request for @justin_ho

    removed review request for @justin_ho

  • mentioned in issue #349317 (closed)

  • Sunjung Park removed review request for @sunjungp

    removed review request for @sunjungp

  • /cc @hollyreynolds

    No need to approve as @sunjungp already has on the UX side just want to make sure you're aware of this change.

  • Kev marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Kev changed the description

    changed the description

  • Kev added 1513 commits

    added 1513 commits

    • 7c6d25e9...f46953d4 - 1510 commits from branch gitlab-org:master
    • ea3b112d - Use normal font weight and border for 'Subscribe' buttons
    • 79a82e7c - Cleanup some of _label partial classes
    • 865cb28b - Use gl-button-text for 'Subscribe' button texts

    Compare with previous version

  • Justin Ho Tuan Duong approved this merge request

    approved this merge request

  • requested review from @pslaughter

  • Sunjung Park requested review from @ealcantara

    requested review from @ealcantara

  • Sunjung Park removed review request for @pslaughter

    removed review request for @pslaughter

  • Enrique Alcántara approved this merge request

    approved this merge request

  • Enrique Alcántara resolved all threads

    resolved all threads

  • Enrique Alcántara enabled an automatic merge when the pipeline for cdaf8717 succeeds

    enabled an automatic merge when the pipeline for cdaf8717 succeeds

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits d0553fc9 and 865cb28b

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.66 MB 3.65 MB -4.7 KB -0.1 %
    mainChunk 2.28 MB 2.28 MB - -0.0 %

    :fearful: Significant Growth: 1

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.projects.security.dast_profiles 1.12 MB 1.16 MB +34.91 KB 3.0 %

    :tada: Significant Reduction: 4

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.trials.create_lead 837.08 KB 126.95 KB -710.12 KB -84.8 %
    pages.trials.new 836.63 KB 129.88 KB -706.75 KB -84.5 %
    pages.groups.security.compliance_dashboards 1.1 MB 998.08 KB -128.42 KB -11.4 %
    pages.trials.select 129.22 KB 125.91 KB -3.31 KB -2.6 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Allure report

    allure-report-publisher generated test report for 865cb28b!

    review-qa-smoke: :pencil: test report
    review-qa-reliable: :pencil: test report

    • Resolved by Kev

      Hi @KevSlashNull,

      We would love to know how you found your code review experience in this merge request! Please leave a :thumbsup: or a :thumbsdown: on this comment to describe your experience.

      Once done, please comment @gitlab-bot feedback below and feel free to leave any additional feedback you have in the same comment.

      Thanks for your help! :heart:

  • mentioned in commit c12dfc3f

  • added workflowcanary label and removed workflowstaging label

  • Kev resolved all threads

    resolved all threads

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading