Skip to content

Add new environment and review app buttons back

Andrew Fontaine requested to merge afontaine/add-buttons-back-to-environments into master

What does this MR do and why?

The new environments page was lacking the new environment and add review apps buttons.

It has been tweaked slightly to take advantage of the action primary and secondary props of the GlTabs, which means I can't take advantage of the GlModalDirective anymore. Instead, I modify the modal to work via v-model to show/hide the modal. This means that the adjustment for the mobile view happens in the GlTabs component now, thereby making the app component template smaller.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Enable the new environments page.

    Feature.enable(:new_environments_table)

  2. View a project's environments page.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Andrew Fontaine

Merge request reports