Skip to content

Give immediate feedback when awarding an issuable

Kev requested to merge KevSlashNull/gitlab:Give-immediate-feedback-when-emoji-reacting-to-a-comment into master

What does this MR do and why?

This makes reactions on issuables appear immediately after clicking. The change makes the UI more “fluid” (source) as it optimistically shows the awarded emoji to the user without having to wait on the backend to process the award.

Screenshots or screen recordings

VD: the user is on an issue page. The user reacts to an issue with an emoji. The selected emoji appears instantly, without a wait time, like it’s the case at the moment.

How to set up and validate locally

  1. Go to an issuable, such as an issue or merge request
  2. React to the issue
  3. See that the awarded emoji was rendered immediately
  4. Remove the reaction
  5. See that the awarded emoji is no longer visible (or the count is 0 for thumbsup/-down)

If an error occurs, the reaction will be reverted.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Kev

Merge request reports