Skip to content

Resolve "Refactor Ipynbdiff Implementation"

Eduardo Bonet requested to merge 347015-refactor-ipynbdiff-implementation into master

What does this MR do and why?

On 14.5 we added custom Jupyter Notebooks Diffs (&6589 (closed)), but the code was scattered and hard to expand on. This MR is purely a refactor of the codebase

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  • Clone https://gitlab.com/gitlab-org/incubation-engineering/mlops/ipynb-test-projects/diff-sample and mirror into your GDK instance
  • Enable the feature flag on GDK:
    • Open the rails consoles (rails c)
    • Feature.enable(:jupyter_clean_diffs)
  • Navigate to the first commit diff https://gdk:3000/<PATH_TO_YOUR_MIRROR>/-/commit/542d42a0196e2e94a0d5793acdee5ba997ab12bf
  • The diff should be displayed as the one in before, both with the changes and without the changes added by this MR.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #347015 (closed)

Edited by Eduardo Bonet

Merge request reports