Skip to content

Improve modal interaction

Savas Vedova requested to merge 344881-address-minor-bugs into master

What does this MR do and why?

This MR addressed the issues mentioned here: #344881 (comment 748218527)

Screenshots or screen recordings

unlink-project

How to set up and validate locally

  1. Go to Project > Security && Compliance > Policies
  2. Interact with the modal

Here are the confusing states which are currently on master:

  1. When user clicks on edit policy project
  2. And changes the selected project
  3. And closes the modal without saving
  4. And reopens the modal
  5. Then they still see the newly selected project.

This is confusing because it looks like the changes were saved, even though they were not.

  1. When user clicks on edit policy project
  2. And has an already selected project
  3. And clicks on the remove button
  4. The design (as mentioned in the comment linked above) empties the project selector

However, the current implementation still keeps the project displayed, which is again, confusing.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #344881 (closed)

Merge request reports