Create labels_as_hash_ concern
What does this MR do?
Places labels_as_hash
logic into a concern.
What are the relevant issue numbers?
Closes #48930 - Tech debt: Extract labels_as_hash
logic into a concern
Does this MR meet the acceptance criteria?
-
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
EE specific content should be in the top level /ee
folder
Merge request reports
Activity
added Plan [DEPRECATED] backend maintenancerefactor labels
changed milestone to %11.4
1 Error 🚫 3f584b16: Commits that change 30 or more lines in more than three files must describe these changes in the commit body 2 Warnings ⚠ CHANGELOG missing. You can create one with:
bin/changelog -m 7563 "Create labels_as_hash_ concern"
If your merge request doesn’t warrant a CHANGELOG entry,
consider adding any of the ~backstage, ~Documentation, QA, test labels.
See the documentation.⚠ 3f584b16: This commit’s subject line could be improved. Commit subjects are ideally no longer than roughly 50 characters, though we allow up to 72 characters in the subject. If possible, try to reduce the length of the subject to roughly 50 characters. Commit message standards
One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.
Here is an example of a good commit message:
Reject ruby interpolation in externalized strings When using ruby interpolation in externalized strings, they can't be detected. Which means they will never be presented to be translated. To mix variables into translations we need to use `sprintf` instead. Instead of: _("Hello #{subject}") Use: _("Hello %{subject}") % { subject: 'world' }
This is an example of a bad commit message:
updated README.md
This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.
Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖marked the checklist item Changelog entry added, if necessary as completed
added 1 commit
- ed503bf3 - Create labels_as_hash_ concern, modify params for method
added 1 commit
- eb102363 - Create labels_as_hash_ concern, modify params for method
added 155 commits
-
eb102363...8da6efc6 - 154 commits from branch
master
- b25528ff - Create labels_as_hash_ concern, modify params for method
-
eb102363...8da6efc6 - 154 commits from branch
Hello @ifarkas, please have a look when you can!
assigned to @ifarkas
- Resolved by Chantal Rollison
Thanks @crollison for the MR! I left one question, otherwise LGTM!
assigned to @crollison
added 1 commit
- 907ed9f2 - Create labels_as_hash_ concern, modify params for method
@ifarkas thank you for having a look, I assigned you to the port if you don't mind checking that one quickly too (I addressed your comment there as well).
Edited by Chantal Rollisonassigned to @ifarkas
Thanks @crollison, LGTM!
assigned to @crollison
Hello @DouweM, please have a look when you can.
assigned to @DouweM
- Resolved by Douwe Maan
assigned to @crollison
- Resolved by Chantal Rollison
added 1 commit
- fc0d8251 - Create labels_as_hash_ concern, modify params for method
marked the checklist item Changelog entry added, if necessary as incomplete
assigned to @DouweM
- Resolved by Chantal Rollison
- Resolved by Chantal Rollison
assigned to @crollison
added 517 commits
-
fc0d8251...1e4a88d4 - 516 commits from branch
master
- 29700560 - Create labels_as_hash_ concern, modify params for method
-
fc0d8251...1e4a88d4 - 516 commits from branch
added 1 commit
- 3f584b16 - Create labels_as_hash_ concern, modify params for method
assigned to @DouweM
mentioned in commit c77896f3
mentioned in issue gitlab-org/release/tasks#473 (closed)
added backstage [DEPRECATED] label
added devopsplan label
added Enterprise Edition label
removed Plan [DEPRECATED] label