Skip to content
Snippets Groups Projects

Create labels_as_hash_ concern

Merged Chantal Rollison requested to merge ccr/48930_extract_logic_to_concern into master
All threads resolved!

What does this MR do?

Places labels_as_hash logic into a concern.

What are the relevant issue numbers?

Closes #48930 - Tech debt: Extract labels_as_hash logic into a concern

Does this MR meet the acceptance criteria?

Edited by Coung Ngo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks @crollison for the MR! I left one question, otherwise LGTM!

  • assigned to @crollison

  • added 1 commit

    • 907ed9f2 - Create labels_as_hash_ concern, modify params for method

    Compare with previous version

  • Author Contributor

    @ifarkas thank you for having a look, I assigned you to the port if you don't mind checking that one quickly too (I addressed your comment there as well).

    Edited by Chantal Rollison
  • Chantal Rollison resolved all discussions

    resolved all discussions

  • Thanks @crollison, LGTM!

  • assigned to @crollison

  • Author Contributor

    Hello @DouweM, please have a look when you can.

  • assigned to @DouweM

  • Douwe Maan
  • assigned to @crollison

  • Douwe Maan
  • added 1 commit

    • fc0d8251 - Create labels_as_hash_ concern, modify params for method

    Compare with previous version

  • Chantal Rollison marked the checklist item Changelog entry added, if necessary as incomplete

    marked the checklist item Changelog entry added, if necessary as incomplete

  • Chantal Rollison changed the description

    changed the description

  • assigned to @DouweM

  • Douwe Maan resolved all discussions

    resolved all discussions

  • Douwe Maan
  • Douwe Maan
  • assigned to @crollison

  • Chantal Rollison added 517 commits

    added 517 commits

    Compare with previous version

  • added 1 commit

    • 3f584b16 - Create labels_as_hash_ concern, modify params for method

    Compare with previous version

  • Chantal Rollison resolved all discussions

    resolved all discussions

  • assigned to @DouweM

  • Douwe Maan approved this merge request

    approved this merge request

  • merged

  • Douwe Maan mentioned in commit c77896f3

    mentioned in commit c77896f3

  • Coung Ngo changed the description

    changed the description

  • Please register or sign in to reply
    Loading