Add prepend_mod to TreeController and Api::Repositories
Add prepend_mod
to Projects::TreeController
and API::Repositories
Related JH Issue:
Related JH MR:
Merge request reports
Activity
- Resolved by Rémy Coutable
cc @gitlab-com/gl-security/appsec this is a JiHu contribution, please follow the JiHu contribution review process
added JiHu contribution label
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
- Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
- If you haven't, please set up a
DANGER_GITLAB_API_TOKEN
. - You can comment
@gitlab-bot label ~"group::"
to add a group label. - After a few days, feel free to ask
@gitlab-bot help
or ping a Merge Request Coach. - Read more on how to get help.
This message was generated automatically. You're welcome to improve it.
added Community contribution label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sarah Yasonik ( @syasonik
) (UTC-5)James Fargher ( @proglottis
) (UTC+13)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Rémy Coutable
@gitlab-bot assign_reviewer @alexbuijs
requested review from @alexbuijs
mentioned in issue gitlab-jh/status-reports#88 (closed)
added 1 commit
- a4a67f98 - Add prepend_mod to TreeController and TreeObject
mentioned in issue gitlab-org/quality/triage-reports#5472 (closed)
added 1 commit
- e199765f - Add prepend_mod to TreeController and Api::Repositories
added 1 commit
- e9300e34 - Add prepend_mod to TreeController and API::Repositories
added 1 commit
- 3dc09834 - Add prepend_mod to TreeController and API::Repositories
requested review from @rymai and removed review request for @alexbuijs
- Resolved by Rémy Coutable
@alexbuijs
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
changed milestone to %14.6
added typemaintenance label
assigned to @zhanglinjie
mentioned in issue gitlab-org/quality/triage-reports#5495 (closed)
requested review from @ngeorge1
added Engineering Productivity + 1 deleted label
- Resolved by Rémy Coutable
mentioned in merge request gitlab-jh/gitlab!128 (closed)
- A deleted user
added backend label
added sec-planningcomplete label
mentioned in commit a6989030
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue gitlab-jh/status-reports#90 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue jh-upstream-report#7 (closed)