Skip to content

Make remove user buttons consistent in admin and groups dashboards

Ammar Alakkad requested to merge 329940-fix-remove-user-in-seat-usage into master

What does this MR do and why?

It makes the delete user button consistent across admin and group management pages.

Screenshots

# has visual changes? path before after
1 /groups/<group_id>/-/usage_quotas#seats-quota-tab Screen_Shot_2021-12-01_at_15.29.23 Screen_Shot_2021-12-01_at_15.29.04
2 /groups/<group_id>/-/group_members Screen_Shot_2021-12-01_at_15.30.37 Screen_Shot_2021-12-01_at_15.31.24
3 /admin/users Screen_Shot_2021-11-30_at_12.40.29 Screen_Shot_2021-11-30_at_12.42.12
4 /admin/users/<username>/projects Screen_Shot_2021-11-30_at_12.43.36 Screen_Shot_2021-11-30_at_12.50.15
5 /groups/<group_id>/-/group_members?tab=invited Screen_Shot_2021-12-01_at_15.32.27 Screen_Shot_2021-12-08_at_14.15.10
6 /groups/<group_id>/-/group_members?tab=groups Screen_Shot_2021-12-01_at_15.13.40 Screen_Shot_2021-12-08_at_14.18.32
7 /groups/<group_id>/-/group_members?tab=access_requests Screen_Shot_2021-12-02_at_19.57.03 Screen_Shot_2021-12-03_at_12.37.59

How to set up and validate locally

  1. Checkout the branch
  2. As root visit /admin and observe the dropdown beside each user
  3. From the previous step, click on one of the users then navigate to the "Groups and projects" tab and observe the delete button beside group(s) and project(s)
  4. As a group owner, navigate to a group's members page (/groups/<group_id>/-/group_members) and observe the "Remove user" button
  5. In a group with a paid plan, from the left sidebar select Settings > Usage Quotas, and observe the "Remove user" button

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #329940 (closed)

Edited by Ammar Alakkad

Merge request reports