Fix n plus one issue ci build dast profile
What does this MR do and why?
As described in #346325 (closed), there are two N+1
issues when multiple builds with the dast_configuration
keyword are present in the YAML
file.
Example:
stages:
- dast
dast:
stage: dast
dast_configuration:
site_profile: dast_site_profile_name
scanner_profile: dast_scanner_profile_name
script:
- exit 0
dast2:
stage: dast
dast_configuration:
site_profile: another_dast_site_profile_name
scanner_profile: another_dast_scanner_profile_name
script:
- exit 0
In order to fix these N+1 issues this Merge Request:
-
Creates a service that takes several builds
andprofiles
and associates them inside a single database insert. -
Extends the profiles finder to batch load profiles.
Before
SELECT "dast_site_profiles".* FROM "dast_site_profiles" WHERE "dast_site_profiles"."project_id" = 2 AND "dast_site_profiles"."name" = 'Portable Receiver 172ca0e6 - 1' ORDER BY "dast_site_profiles"."id" ASC LIMIT 1 /*application:test,correlation_id:1d5d62b143cc80539f1417a2e0b7c529,db_config_name:main*/
SELECT "dast_sites".* FROM "dast_sites" WHERE "dast_sites"."id" = 3 /*application:test,correlation_id:1d5d62b143cc80539f1417a2e0b7c529,db_config_name:main*/
SELECT "dast_scanner_profiles".* FROM "dast_scanner_profiles" WHERE "dast_scanner_profiles"."project_id" = 2 AND "dast_scanner_profiles"."name" = 'GPS Bridge 7848fd8e - 1' ORDER BY "dast_scanner_profiles"."id" ASC LIMIT 1 /*application:test,correlation_id:1d5d62b143cc80539f1417a2e0b7c529,db_config_name:main*/
INSERT INTO "dast_site_profiles_builds" ("dast_site_profile_id", "ci_build_id") VALUES (3, 7) /*application:test,correlation_id:1d5d62b143cc80539f1417a2e0b7c529,db_config_name:main*/
INSERT INTO "dast_scanner_profiles_builds" ("dast_scanner_profile_id", "ci_build_id") VALUES (3, 7) /*application:test,correlation_id:1d5d62b143cc80539f1417a2e0b7c529,db_config_name:main*/
SELECT "dast_site_profiles".* FROM "dast_site_profiles" WHERE "dast_site_profiles"."project_id" = 2 AND "dast_site_profiles"."name" = 'Power Bridge a5ed6674 - 2' ORDER BY "dast_site_profiles"."id" ASC LIMIT 1 /*application:test,correlation_id:1d5d62b143cc80539f1417a2e0b7c529,db_config_name:main*/
SELECT "dast_sites".* FROM "dast_sites" WHERE "dast_sites"."id" = 4 /*application:test,correlation_id:1d5d62b143cc80539f1417a2e0b7c529,db_config_name:main*/
SELECT "dast_scanner_profiles".* FROM "dast_scanner_profiles" WHERE "dast_scanner_profiles"."project_id" = 2 AND "dast_scanner_profiles"."name" = 'Video System f5efa6ec - 2' ORDER BY "dast_scanner_profiles"."id" ASC LIMIT 1 /*application:test,correlation_id:1d5d62b143cc80539f1417a2e0b7c529,db_config_name:main*/
INSERT INTO "dast_site_profiles_builds" ("dast_site_profile_id", "ci_build_id") VALUES (4, 8) /*application:test,correlation_id:1d5d62b143cc80539f1417a2e0b7c529,db_config_name:main*/
INSERT INTO "dast_scanner_profiles_builds" ("dast_scanner_profile_id", "ci_build_id") VALUES (4, 8) /*application:test,correlation_id:1d5d62b143cc80539f1417a2e0b7c529,db_config_name:main*/
After
SELECT "dast_site_profiles".* FROM "dast_site_profiles" WHERE "dast_site_profiles"."project_id" = 1 AND "dast_site_profiles"."name" IN ('Power Bridge c1085309 - 1', 'Electric GPS Compressor f3adb06f - 2')
SELECT "dast_sites".* FROM "dast_sites" WHERE "dast_sites"."id" IN (2, 1)
SELECT "dast_scanner_profiles".* FROM "dast_scanner_profiles" WHERE "dast_scanner_profiles"."name" IN ('Auto Case 657d053e - 1', 'Digital Transmitter 3c2c49e0 - 2')
INSERT INTO "dast_site_profiles_builds" ("ci_build_id","dast_site_profile_id") VALUES (3, 1), (4, 2) ON CONFLICT ("ci_build_id") DO NOTHING RETURNING "dast_site_profile_id","ci_build_id"
INSERT INTO "dast_scanner_profiles_builds" ("ci_build_id","dast_scanner_profile_id") VALUES (3, 1), (4, 2) ON CONFLICT ("ci_build_id") DO NOTHING RETURNING "dast_scanner_profile_id","ci_build_id"
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @mc_rocha
- A deleted user
added backend label
9 Warnings b3070bbc: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 05f1ce88: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. d9bf9256: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. df2efd71: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. c3cfdc11: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 342c6572: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 081cad73: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. df967e3a: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 5e31dbc2: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the
danger-review
job.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Marc Shaw ( @marc_shaw
) (UTC+1)Tetiana Chupryna ( @brytannia
) (UTC+2)database Maxime Orefice ( @morefice
) (UTC+1)Patrick Bair ( @pbair
) (UTC-5)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerSetting label groupdynamic analysis based on
@mc_rocha
's group.added groupdynamic analysis label
Setting label(s) devopssecure sectionsec based on groupdynamic analysis.
added devopssecure sectionsec labels
- Resolved by Philip Cunningham
mentioned in commit 34431e97
added 1 commit
- 34431e97 - Fix N+1 issue when associating DAST profiles and CI Builds
- A deleted user
added database databasereview pending labels
mentioned in commit 2475bb8a
added 1021 commits
-
34431e97...c1a020ce - 1015 commits from branch
master
- c7fb681e - Fix n+1 issue when associating DAST profiles and CI Builds
- 3d194257 - Fix n+1 issue when associating DAST profiles and CI Builds
- c1c8c839 - Fix n+1 issue when associating DAST profiles and CI Builds
- cc64c8b8 - Update DAST Association Service
- 2475bb8a - Fix N+1 issue when associating DAST profiles and CI Builds
- 80d783a2 - Fix N+1 issue when associating DAST profiles and CI Builds
Toggle commit list-
34431e97...c1a020ce - 1015 commits from branch
added 1 commit
- d7f3503e - Fix N+1 issue when associating DAST profiles and CI Builds
mentioned in commit d034b993
added 612 commits
-
3fe85d2f...c4d19a2e - 602 commits from branch
master
- 2fedade2 - Fix n+1 issue when associating DAST profiles and CI Builds
- 7243830a - Fix n+1 issue when associating DAST profiles and CI Builds
- 787b8ff1 - Fix n+1 issue when associating DAST profiles and CI Builds
- e490fe4a - Update DAST Association Service
- d034b993 - Fix N+1 issue when associating DAST profiles and CI Builds
- e20924a9 - Fix N+1 issue when associating DAST profiles and CI Builds
- 4284808b - Fix N+1 issue when associating DAST profiles and CI Builds
- f8b6632c - Fix N+1 issue when associating DAST profiles and CI Builds
- 81275933 - Fix N+1 issue when associating DAST profiles and CI Builds
- 5c4b3e9b - Fix broken tests
Toggle commit list-
3fe85d2f...c4d19a2e - 602 commits from branch
mentioned in commit 86e3ae11
added 150 commits
-
5c4b3e9b...ce272f6b - 139 commits from branch
master
- 159f0514 - Fix n+1 issue when associating DAST profiles and CI Builds
- 5b5a054c - Fix n+1 issue when associating DAST profiles and CI Builds
- 24e5dd73 - Fix n+1 issue when associating DAST profiles and CI Builds
- ddecdc05 - Update DAST Association Service
- 86e3ae11 - Fix N+1 issue when associating DAST profiles and CI Builds
- 1456e18c - Fix N+1 issue when associating DAST profiles and CI Builds
- 9b13200e - Fix N+1 issue when associating DAST profiles and CI Builds
- b41cbb56 - Fix N+1 issue when associating DAST profiles and CI Builds
- 3229c2a9 - Fix N+1 issue when associating DAST profiles and CI Builds
- 6c1fd508 - Fix broken tests
- f2c5e837 - Fix broken tests
Toggle commit list-
5c4b3e9b...ce272f6b - 139 commits from branch
mentioned in commit 7f5bb130
added 43 commits
-
d251adef...735681f8 - 30 commits from branch
master
- 493a07ca - Fix n+1 issue when associating DAST profiles and CI Builds
- 577d2b56 - Fix n+1 issue when associating DAST profiles and CI Builds
- 9f8d1c85 - Fix n+1 issue when associating DAST profiles and CI Builds
- 89d60298 - Update DAST Association Service
- 7f5bb130 - Fix N+1 issue when associating DAST profiles and CI Builds
- 3ef6ed61 - Fix N+1 issue when associating DAST profiles and CI Builds
- 353fdea2 - Fix N+1 issue when associating DAST profiles and CI Builds
- c9f868b1 - Fix N+1 issue when associating DAST profiles and CI Builds
- 8d115b00 - Fix N+1 issue when associating DAST profiles and CI Builds
- 9f5161ba - Fix broken tests
- df3ceb4c - Fix broken tests
- d39f39a1 - Fix broken tests
- 1f5bf588 - Fix n plus one issue associating pipeline and ci builds
Toggle commit list-
d251adef...735681f8 - 30 commits from branch
added 1 commit
- b596d549 - Fix n plus one issue associating pipeline and ci builds
- Resolved by Philip Cunningham
changed milestone to %14.6
mentioned in commit 11162ef4
added 491 commits
-
4f6e47d6...8416c08e - 475 commits from branch
master
- a0dc81ff - Fix n+1 issue when associating DAST profiles and CI Builds
- d16bcde1 - Fix n+1 issue when associating DAST profiles and CI Builds
- 6326c801 - Fix n+1 issue when associating DAST profiles and CI Builds
- e0a7c6c7 - Update DAST Association Service
- 11162ef4 - Fix N+1 issue when associating DAST profiles and CI Builds
- b6c869a9 - Fix N+1 issue when associating DAST profiles and CI Builds
- 694ac7a8 - Fix N+1 issue when associating DAST profiles and CI Builds
- 4b6bfc8e - Fix N+1 issue when associating DAST profiles and CI Builds
- 40a70ab8 - Fix N+1 issue when associating DAST profiles and CI Builds
- 897b569f - Fix broken tests
- 5127df07 - Fix broken tests
- 488bb80a - Fix broken tests
- 403b5b31 - Fix n plus one issue associating pipeline and ci builds
- 46dab43c - Fix n plus one issue associating pipeline and ci builds
- d75162df - Fix rubocop offense
- 3be7453a - Refactoring CreateAssociationsService
Toggle commit list-
4f6e47d6...8416c08e - 475 commits from branch
mentioned in commit 86cbfbdc
added 413 commits
-
3be7453a...3cea1a51 - 396 commits from branch
master
- a5fd5db0 - Fix n+1 issue when associating DAST profiles and CI Builds
- 0b3af351 - Fix n+1 issue when associating DAST profiles and CI Builds
- a36faca8 - Fix n+1 issue when associating DAST profiles and CI Builds
- 159e6ea7 - Update DAST Association Service
- 86cbfbdc - Fix N+1 issue when associating DAST profiles and CI Builds
- fe05ba29 - Fix N+1 issue when associating DAST profiles and CI Builds
- 681565c2 - Fix N+1 issue when associating DAST profiles and CI Builds
- a172ee2c - Fix N+1 issue when associating DAST profiles and CI Builds
- c5fbb8b2 - Fix N+1 issue when associating DAST profiles and CI Builds
- 0810d549 - Fix broken tests
- aebadb07 - Fix broken tests
- d1d10855 - Fix broken tests
- 7852a990 - Fix n plus one issue associating pipeline and ci builds
- 17194219 - Fix n plus one issue associating pipeline and ci builds
- 090ebcf4 - Fix rubocop offense
- 1335b3fb - Refactoring CreateAssociationsService
- 88350d5a - Add tests for dast profiles
Toggle commit list-
3be7453a...3cea1a51 - 396 commits from branch
- Resolved by Philip Cunningham
- Resolved by Philip Cunningham
- Resolved by Philip Cunningham
- Resolved by Philip Cunningham
- Resolved by Philip Cunningham
- Resolved by Philip Cunningham
added 2 commits
mentioned in commit 6b686371
added 276 commits
-
18be4371...b990dc7a - 254 commits from branch
master
- 9f581e2d - Fix n+1 issue when associating DAST profiles and CI Builds
- 4f72ff46 - Fix n+1 issue when associating DAST profiles and CI Builds
- b1ac0b97 - Fix n+1 issue when associating DAST profiles and CI Builds
- 8a7df2b1 - Update DAST Association Service
- 6b686371 - Fix N+1 issue when associating DAST profiles and CI Builds
- 0debf63f - Fix N+1 issue when associating DAST profiles and CI Builds
- 6f284b79 - Fix N+1 issue when associating DAST profiles and CI Builds
- 686f36ea - Fix N+1 issue when associating DAST profiles and CI Builds
- 5a1101c0 - Fix N+1 issue when associating DAST profiles and CI Builds
- 41a3bedc - Fix broken tests
- 5ed688c6 - Fix broken tests
- 740c9c78 - Fix broken tests
- 624ef3c8 - Fix n plus one issue associating pipeline and ci builds
- 27702d5a - Fix n plus one issue associating pipeline and ci builds
- b02df75c - Fix rubocop offense
- 3944890a - Refactoring CreateAssociationsService
- 2a490396 - Add tests for dast profiles
- 6c44b620 - Add tests for CreateAssociationsService
- 9d7819a1 - Add tests for CreateAssociationsService
- 3fb98c5a - CreateAssociationsService Refactoring
- 82edaf83 - CreateAssociationsService Refactoring
- 0f41e9b0 - Update CreateAssociationsService response
Toggle commit list-
18be4371...b990dc7a - 254 commits from branch
added pipeline:skip-undercoverage label
mentioned in commit 3f5c1193
added 305 commits
-
0f41e9b0...25a499e9 - 283 commits from branch
master
- 91e45dc2 - Fix n+1 issue when associating DAST profiles and CI Builds
- 4d141f34 - Fix n+1 issue when associating DAST profiles and CI Builds
- 6f84f13f - Fix n+1 issue when associating DAST profiles and CI Builds
- 374afecb - Update DAST Association Service
- 3f5c1193 - Fix N+1 issue when associating DAST profiles and CI Builds
- d688e428 - Fix N+1 issue when associating DAST profiles and CI Builds
- abb330c2 - Fix N+1 issue when associating DAST profiles and CI Builds
- 5f7210b6 - Fix N+1 issue when associating DAST profiles and CI Builds
- 770685e5 - Fix N+1 issue when associating DAST profiles and CI Builds
- fc0bc819 - Fix broken tests
- 912ad7ef - Fix broken tests
- 0d289dcb - Fix broken tests
- a0f382ff - Fix n plus one issue associating pipeline and ci builds
- 6209fdec - Fix n plus one issue associating pipeline and ci builds
- a6e54a3e - Fix rubocop offense
- 5111496b - Refactoring CreateAssociationsService
- 9d37940e - Add tests for dast profiles
- 5d667f7b - Add tests for CreateAssociationsService
- b9260453 - Add tests for CreateAssociationsService
- 524498ed - CreateAssociationsService Refactoring
- 9b2fc9b4 - CreateAssociationsService Refactoring
- 142ccfa9 - Update CreateAssociationsService response
Toggle commit list-
0f41e9b0...25a499e9 - 283 commits from branch
requested review from @philipcunningham
- Resolved by Tetiana Chupryna
- Resolved by Philip Cunningham
thanks @mc_rocha! i ran out of time today but i'll review the changes tomorrow morning.
changed milestone to %14.7
added missed:14.6 label
- Resolved by Cameron Swords
- Resolved by Cameron Swords
- Resolved by Marcos Rocha
- Resolved by Cameron Swords
- Resolved by Cameron Swords
- Resolved by Cameron Swords
- Resolved by Tetiana Chupryna
thanks @mc_rocha! i've added some thoughts for your consideration. back to you
please
@
me and re-assign me as reviewer when you'd like me to have another look.
removed review request for @philipcunningham
mentioned in commit cd3d030f
mentioned in commit fb0d2bff
added 321 commits
-
a3984a2b...26e2c6c1 - 290 commits from branch
master
- 4d5b917b - Fix n+1 issue when associating DAST profiles and CI Builds
- 4ca412e9 - Fix n+1 issue when associating DAST profiles and CI Builds
- 35e97652 - Fix n+1 issue when associating DAST profiles and CI Builds
- 415daa45 - Update DAST Association Service
- fb0d2bff - Fix N+1 issue when associating DAST profiles and CI Builds
- 4cec5101 - Fix N+1 issue when associating DAST profiles and CI Builds
- e40a7594 - Fix N+1 issue when associating DAST profiles and CI Builds
- 5cd8c022 - Fix N+1 issue when associating DAST profiles and CI Builds
- bcd70dcb - Fix N+1 issue when associating DAST profiles and CI Builds
- a8b609bf - Fix broken tests
- 4e109144 - Fix broken tests
- 3b87bc89 - Fix broken tests
- 1e26dbdf - Fix n plus one issue associating pipeline and ci builds
- 83faf90c - Fix n plus one issue associating pipeline and ci builds
- 7a35a10c - Fix rubocop offense
- 4304de3b - Refactoring CreateAssociationsService
- 8bb54ccb - Add tests for dast profiles
- b7fa1819 - Add tests for CreateAssociationsService
- eb6111ed - Add tests for CreateAssociationsService
- 84038733 - CreateAssociationsService Refactoring
- 1b3ec318 - CreateAssociationsService Refactoring
- 17f6015b - Update CreateAssociationsService response
- b3a2e7bd - Fix n+1 issue when associating DAST profiles and CI Builds
- 6f7f8b55 - Update DAST Association Service
- cd3d030f - Fix N+1 issue when associating DAST profiles and CI Builds
- 67d2928f - Fix N+1 issue when associating DAST profiles and CI Builds
- cfeed0d6 - Fix N+1 issue when associating DAST profiles and CI Builds
- 6b5a9b2e - Fix broken tests
- 56245609 - Add tests for CreateAssociationsService
- 252ac837 - Improve code readability
- 3c7254ae - Address merge request suggestions
Toggle commit list-
a3984a2b...26e2c6c1 - 290 commits from branch
requested review from @cam_swords
removed review request for @cam_swords
@cam_swords
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @nmilojevic1
added databasereviewed label and removed databasereview pending label
requested review from @a_akgun and removed review request for @nmilojevic1
removed review request for @a_akgun
mentioned in commit 346c7110
mentioned in commit 88f5f7d7
added 767 commits
-
553d91af...ed67f0e8 - 733 commits from branch
master
- d8ef5dee - Fix n+1 issue when associating DAST profiles and CI Builds
- a685c769 - Fix n+1 issue when associating DAST profiles and CI Builds
- 92a4b195 - Fix n+1 issue when associating DAST profiles and CI Builds
- 258b3393 - Update DAST Association Service
- 88f5f7d7 - Fix N+1 issue when associating DAST profiles and CI Builds
- f1353070 - Fix N+1 issue when associating DAST profiles and CI Builds
- 18c1abef - Fix N+1 issue when associating DAST profiles and CI Builds
- 93465353 - Fix N+1 issue when associating DAST profiles and CI Builds
- 52d749a6 - Fix N+1 issue when associating DAST profiles and CI Builds
- 7bc6d7ea - Fix broken tests
- 196e48a4 - Fix broken tests
- fdeb1d7d - Fix broken tests
- 5022ce79 - Fix n plus one issue associating pipeline and ci builds
- c8a3a190 - Fix n plus one issue associating pipeline and ci builds
- cff7645b - Fix rubocop offense
- c57cb841 - Refactoring CreateAssociationsService
- 3696dda4 - Add tests for dast profiles
- ad752ab3 - Add tests for CreateAssociationsService
- 2672fe65 - Add tests for CreateAssociationsService
- e8dc777c - CreateAssociationsService Refactoring
- 050ccb64 - CreateAssociationsService Refactoring
- 725cbc8b - Update CreateAssociationsService response
- bfa04311 - Fix n+1 issue when associating DAST profiles and CI Builds
- fd29404f - Update DAST Association Service
- 346c7110 - Fix N+1 issue when associating DAST profiles and CI Builds
- 2f8e8b75 - Fix N+1 issue when associating DAST profiles and CI Builds
- ae5ff981 - Fix N+1 issue when associating DAST profiles and CI Builds
- 68853bc1 - Fix broken tests
- aa1f0e13 - Add tests for CreateAssociationsService
- 25cd4ee9 - Improve code readability
- 08127ead - Address merge request suggestions
- a97695d6 - Fix shared examples
- eca1d15e - Fix broken test
- 48ece80f - Remove unnecessary guard clause
Toggle commit list-
553d91af...ed67f0e8 - 733 commits from branch
mentioned in commit c4d7f671
mentioned in commit fe19bc2d
added 332 commits
-
48ece80f...96110427 - 298 commits from branch
master
- a4eee1dc - Fix n+1 issue when associating DAST profiles and CI Builds
- e981d340 - Fix n+1 issue when associating DAST profiles and CI Builds
- a3dfec5c - Fix n+1 issue when associating DAST profiles and CI Builds
- 2d496f86 - Update DAST Association Service
- c4d7f671 - Fix N+1 issue when associating DAST profiles and CI Builds
- 1a4d98ad - Fix N+1 issue when associating DAST profiles and CI Builds
- 880bbdc0 - Fix N+1 issue when associating DAST profiles and CI Builds
- 3ff18fb0 - Fix N+1 issue when associating DAST profiles and CI Builds
- 9b5868f4 - Fix N+1 issue when associating DAST profiles and CI Builds
- 755897d6 - Fix broken tests
- d671e154 - Fix broken tests
- 349ef6ae - Fix broken tests
- 27385e79 - Fix n plus one issue associating pipeline and ci builds
- 7804fd4b - Fix n plus one issue associating pipeline and ci builds
- 2bfad511 - Fix rubocop offense
- 54ab4ae2 - Refactoring CreateAssociationsService
- dc4a9a41 - Add tests for dast profiles
- 4416a738 - Add tests for CreateAssociationsService
- 4e6c45cc - Add tests for CreateAssociationsService
- 824bf400 - CreateAssociationsService Refactoring
- 6455b834 - CreateAssociationsService Refactoring
- dab4472b - Update CreateAssociationsService response
- 2f0612bd - Fix n+1 issue when associating DAST profiles and CI Builds
- 58b470d1 - Update DAST Association Service
- fe19bc2d - Fix N+1 issue when associating DAST profiles and CI Builds
- fd7ad557 - Fix N+1 issue when associating DAST profiles and CI Builds
- b3b00f5d - Fix N+1 issue when associating DAST profiles and CI Builds
- 5e3aa910 - Fix broken tests
- fe7e2475 - Add tests for CreateAssociationsService
- 7c954d4e - Improve code readability
- c7170b13 - Address merge request suggestions
- 1b2fc5ec - Fix shared examples
- 2fb28185 - Fix broken test
- ea9080b4 - Remove unnecessary guard clause
Toggle commit list-
48ece80f...96110427 - 298 commits from branch
mentioned in commit 84a3e0c5
mentioned in commit 22d20aad
added 249 commits
-
ea9080b4...50df24e4 - 215 commits from branch
master
- 1ac2f3e3 - Fix n+1 issue when associating DAST profiles and CI Builds
- eaeb6704 - Fix n+1 issue when associating DAST profiles and CI Builds
- 90b261e6 - Fix n+1 issue when associating DAST profiles and CI Builds
- 0dd26254 - Update DAST Association Service
- 22d20aad - Fix N+1 issue when associating DAST profiles and CI Builds
- 24ffcb65 - Fix N+1 issue when associating DAST profiles and CI Builds
- 9f6783b7 - Fix N+1 issue when associating DAST profiles and CI Builds
- ede43bd5 - Fix N+1 issue when associating DAST profiles and CI Builds
- 6528781c - Fix N+1 issue when associating DAST profiles and CI Builds
- 8d39f67f - Fix broken tests
- 919d26f5 - Fix broken tests
- a2f8bfb7 - Fix broken tests
- bb58e21a - Fix n plus one issue associating pipeline and ci builds
- 9e828e39 - Fix n plus one issue associating pipeline and ci builds
- 7df8595d - Fix rubocop offense
- 412b352b - Refactoring CreateAssociationsService
- 09a3839f - Add tests for dast profiles
- 3ff9a8d3 - Add tests for CreateAssociationsService
- 7e27462d - Add tests for CreateAssociationsService
- 4f8b4c43 - CreateAssociationsService Refactoring
- d948183b - CreateAssociationsService Refactoring
- fd7753c1 - Update CreateAssociationsService response
- d8e2d623 - Fix n+1 issue when associating DAST profiles and CI Builds
- b9dcd5c6 - Update DAST Association Service
- 84a3e0c5 - Fix N+1 issue when associating DAST profiles and CI Builds
- 3d1aa832 - Fix N+1 issue when associating DAST profiles and CI Builds
- 728773ff - Fix N+1 issue when associating DAST profiles and CI Builds
- f4c9e8ee - Fix broken tests
- e7c5e528 - Add tests for CreateAssociationsService
- 1af7adb6 - Improve code readability
- 1de6c730 - Address merge request suggestions
- 659f6ccf - Fix shared examples
- 39700bc7 - Fix broken test
- 91c8e91a - Remove unnecessary guard clause
Toggle commit list-
ea9080b4...50df24e4 - 215 commits from branch
requested review from @a_akgun
- Resolved by Tetiana Chupryna
Thanks @mc_rocha database LGTM.
removed review request for @a_akgun
requested review from @brytannia
- Resolved by Tetiana Chupryna
- Resolved by Tetiana Chupryna
- Resolved by Marcos Rocha
thanks @mc_rocha, nice work!
and special thanks for @philipcunningham for the nice reviewMarcos, I left two non-blocking questions about errors for your concideration. Also, could you please address danger suggestions !75448 (comment 745381370)? We probably need squash, merge request type label and changelog entry (probably
performance
)
added typemaintenance label
mentioned in commit b3ff21a1
mentioned in commit 089d417b
mentioned in commit 6f487308
added 438 commits
-
91c8e91a...b259d408 - 404 commits from branch
master
- 7db6cf6d - Fix n+1 issue when associating DAST profiles and CI Builds
- d57c8afa - Fix n+1 issue when associating DAST profiles and CI Builds
- 764f24b5 - Fix n+1 issue when associating DAST profiles and CI Builds
- ffd2363b - Update DAST Association Service
- 089d417b - Fix N+1 issue when associating DAST profiles and CI Builds
- 8932f1ea - Fix N+1 issue when associating DAST profiles and CI Builds
- 3776b7f1 - Fix N+1 issue when associating DAST profiles and CI Builds
- 7c2f6cc6 - Fix N+1 issue when associating DAST profiles and CI Builds
- 25dc3742 - Fix N+1 issue when associating DAST profiles and CI Builds
- e77d30d6 - Fix broken tests
- a8e420e9 - Fix broken tests
- e238fb06 - Fix broken tests
- d0ad1208 - Fix n plus one issue associating pipeline and ci builds
- e3f85fc5 - Fix n plus one issue associating pipeline and ci builds
- e2ee0b72 - Fix rubocop offense
- 30beae64 - Refactoring CreateAssociationsService
- e93d378f - Add tests for dast profiles
- a79680a2 - Add tests for CreateAssociationsService
- 9c68845c - Add tests for CreateAssociationsService
- f2a5561b - CreateAssociationsService Refactoring
- 0afb6e82 - CreateAssociationsService Refactoring
- 7abbcb23 - Update CreateAssociationsService response
- f312e911 - Fix n+1 issue when associating DAST profiles and CI Builds
- c6cd9ce8 - Update DAST Association Service
- b3ff21a1 - Fix N+1 issue when associating DAST profiles and CI Builds
- 13d77c36 - Fix N+1 issue when associating DAST profiles and CI Builds
- 4eb33b80 - Fix N+1 issue when associating DAST profiles and CI Builds
- f37e4e1e - Fix broken tests
- 7f980a23 - Add tests for CreateAssociationsService
- a448a9ac - Improve code readability
- 53c50534 - Address merge request suggestions
- 739fdda4 - Fix shared examples
- 5c9d8107 - Fix broken test
- 6f487308 - Fix n plus one issue ci build dast profile
Toggle commit list-
91c8e91a...b259d408 - 404 commits from branch
added bugperformance label
enabled an automatic merge when the pipeline for 4cb40f3f succeeds
mentioned in commit d9bf9256
mentioned in commit df967e3a
mentioned in commit b3070bbc
added 257 commits
-
6f487308...d58a6c69 - 223 commits from branch
master
- 5e31dbc2 - Fix n+1 issue when associating DAST profiles and CI Builds
- c60e5e10 - Fix n+1 issue when associating DAST profiles and CI Builds
- 35c31b05 - Fix n+1 issue when associating DAST profiles and CI Builds
- 25cadb0c - Update DAST Association Service
- df967e3a - Fix N+1 issue when associating DAST profiles and CI Builds
- 02a08628 - Fix N+1 issue when associating DAST profiles and CI Builds
- 42e00edb - Fix N+1 issue when associating DAST profiles and CI Builds
- 081cad73 - Fix N+1 issue when associating DAST profiles and CI Builds
- 42735d81 - Fix N+1 issue when associating DAST profiles and CI Builds
- 0a10fd40 - Fix broken tests
- fdbbf72c - Fix broken tests
- 4e68b42f - Fix broken tests
- 1bbc8cad - Fix n plus one issue associating pipeline and ci builds
- 8bb4ce04 - Fix n plus one issue associating pipeline and ci builds
- a2f69bf5 - Fix rubocop offense
- 342c6572 - Refactoring CreateAssociationsService
- 0eb6e261 - Add tests for dast profiles
- 254792a3 - Add tests for CreateAssociationsService
- 884f339a - Add tests for CreateAssociationsService
- c3cfdc11 - CreateAssociationsService Refactoring
- df2efd71 - CreateAssociationsService Refactoring
- f32364ce - Update CreateAssociationsService response
- 6bec59df - Fix n+1 issue when associating DAST profiles and CI Builds
- ee822133 - Update DAST Association Service
- d9bf9256 - Fix N+1 issue when associating DAST profiles and CI Builds
- 669fdde3 - Fix N+1 issue when associating DAST profiles and CI Builds
- 904b8116 - Fix N+1 issue when associating DAST profiles and CI Builds
- 1d5adf54 - Fix broken tests
- 294ad1ad - Add tests for CreateAssociationsService
- a413a873 - Improve code readability
- 05f1ce88 - Address merge request suggestions
- 8a0a4ba5 - Fix shared examples
- 21c0c8d9 - Fix broken test
- b3070bbc - Fix n plus one issue ci build dast profile
Toggle commit list-
6f487308...d58a6c69 - 223 commits from branch
mentioned in issue #350352 (closed)
mentioned in commit 99114abe
mentioned in commit 1136d945
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!562 (merged)
mentioned in issue #360676 (closed)