Expose failed import error through API
What does this MR do and why?
Gitlab already have a projects/:id/import
(https://docs.gitlab.com/ee/api/project_import_export.html#import-status) to expose the import status
of the given project. This endpoint exposes "hard_failures", which are
errors that caused the import to fail.
This commit, changes the Gitlab::Import::ImportFailureService to create
the failure record with the retry_count: 0
, when it's failing the
import. The retry_count: 0
is is the condition to expose the failure
as a "hard_failure" in the API.
Related to: #346652 (closed)
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added devopsmanage + 1 deleted label
assigned to @kassio
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Mehmet Emin Inac ( @minac
) (UTC+1, 1 hour ahead of@kassio
)Vasilii Iakliushin ( @vyaklushin
) (UTC+1, 1 hour ahead of@kassio
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in commit 7d643aaa
changed milestone to %14.6
- Resolved by Tetiana Chupryna
@dstull, could you do the review of this one, please?
requested review from @dstull
mentioned in commit 79e80b52
added sectiondev label
@dstull
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Tetiana Chupryna
removed review request for @dstull
added typemaintenance label
requested review from @brytannia