Skip to content

Move project related usage quotas code to a shared folder

Sheldon Led requested to merge led/fe-usage-quotas-refactor-1 into master

What does this MR do and why?

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/346506

This is the first of a series of MRs that will move components related to Usage Quotas to a shared place, so that it can be reused between Group, Profile/Personal, and Project usage quotas.

For this first step, we're moving components related to Project Storage

When moving files from one folder to another I had to adjust the code a bit, and by doing that I found some quick win changes:

  • Remove some unused code
  • Give more meaningful names to some components
  • Change deprecated_project_avatar to the new one

Screenshots or screen recordings

Project Usage Quotas - storage

For Project Storage, there should be no difference in the UI

Before After
project_usage_quotas_storage-quota-tab_before project_usage_quotas_storage-quota-tab_after

Group Usage Quotas - storage

For Group Storage, there's an improvement on the Project Storage Detail (the project storage table), but the rest should be the same

Before After
group_usage_quotas_storage-quota-tab_before group_usage_quotas_storage-quota-tab_after

Personal Usage Quotas - storage

Same improvement on Project Storage Detail as we have in Group Usage Quotas.

Before After
personal_usage_quotas_storage-quota-tab_before personal_usage_quotas_storage-quota-tab_after

How to set up and validate locally

  1. Check out this branch and visit each page:
  2. Project: /my_group/my_project/-/usage_quotas#storage-quota-tab
  3. Group: /groups/my_group/-/usage_quotas#storage-quota-tab
  4. Profile: /-/profile/usage_quotas#storage-quota-tab

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sheldon Led

Merge request reports