Port UpgradeCommand to CE
What does this MR do?
Port utility classes and new helm application status codes to CE (CE MR)
The rest can be ported in a future MR (https://gitlab.com/gitlab-org/gitlab-ce/issues/52032):
ee/app/services/clusters/applications/check_upgrade_progress_service.rb
ee/app/workers/cluster_wait_for_app_update_worker.rb
-
ee/app/models/ee/clusters/applications/prometheus.rb
but generalise to all applications !
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/49952
Tasks
-
Port ::Gitlab::Kubernetes::Helm::UpgradeCommand
to CE -
Port EE::Clusters::ApplicationStatus
to CE -
Port EE::Gitlab::Kubernetes::Helm::Api
to CE -
Port spec/factories/clusters/applications/helm.rb
to CE
Manual QA
-
Manual Regression Test for Prometheus Alerting
- setup a custom Prometheus metric (Settings, Integrations, Prometheus)
- Go to the Metrics page (Operations, Metrics). Expand the alert button on your custom metric, set up any alert.
- Wait for the alert to complete re-configuring the Prometheus on the cluster. (it will then set the database value for the
status
of theClusters::Applications::Prometheus
record to5
.- new
prometheus-alertmanager
pod should be created -
helm ls
for prometheus would have a new release
- new
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan?
Edited by Thong Kuah