Skip to content

Port UpgradeCommand to CE

Thong Kuah requested to merge ee-49952-port-upgrade-command-to-ce into master

What does this MR do?

Port utility classes and new helm application status codes to CE (CE MR)

The rest can be ported in a future MR (https://gitlab.com/gitlab-org/gitlab-ce/issues/52032):

  • ee/app/services/clusters/applications/check_upgrade_progress_service.rb
  • ee/app/workers/cluster_wait_for_app_update_worker.rb
  • ee/app/models/ee/clusters/applications/prometheus.rb but generalise to all applications !

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/49952

Tasks

  • Port ::Gitlab::Kubernetes::Helm::UpgradeCommand to CE
  • Port EE::Clusters::ApplicationStatus to CE
  • Port EE::Gitlab::Kubernetes::Helm::Api to CE
  • Port spec/factories/clusters/applications/helm.rb to CE

Manual QA

  • Manual Regression Test for Prometheus Alerting
  1. setup a custom Prometheus metric (Settings, Integrations, Prometheus)
  2. Go to the Metrics page (Operations, Metrics). Expand the alert button on your custom metric, set up any alert.
  3. Wait for the alert to complete re-configuring the Prometheus on the cluster. (it will then set the database value for the status of the Clusters::Applications::Prometheus record to 5.
    • new prometheus-alertmanager pod should be created
    • helm ls for prometheus would have a new release

Does this MR meet the acceptance criteria?

Edited by Thong Kuah

Merge request reports