Skip to content

Label for depending merge requests unnecessarily escapes HTML

What does this MR do and why?

When a merge request has dependencies, if a dependent merge request has been closed, it escapes the <strong> and </strong> on the page rather than rendering it correctly.

Screenshots or screen recordings

Before After
Screen_Shot_2021-11-24_at_00.21.38 Screen_Shot_2021-11-24_at_00.22.42

How to set up and validate locally

  1. With EE enabled, go to http://localhost:3000/gitlab-org/gitlab-test/-/merge_requests/2/edit
  2. Add the Merge Request dependencies /twitter/Typeahead.Js!1, /twitter/Typeahead.Js!2, and /flightjs/Flight!4
  3. Go to http://localhost:3000/twitter/Typeahead.Js/-/merge_requests/2 and close the MR
  4. Visit http://localhost:3000/gitlab-org/gitlab-test/-/merge_requests/2 and see the text in the After screenshot appears

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

note: GitPod VSCode was pretty intent on reformatting it into multiple lines!

Closes #346344

Edited by David Barr

Merge request reports