Skip to content

Remove unused cluster runner creation code causing cross-modification

Dylan Griffith requested to merge 346315-remove-unused-cluster-management-runner-creation into master

What does this MR do and why?

As discovered at !74735 (comment 740614507) this code causes a CrossDatabaseModificationAcrossUnsupportedTablesError since it writes to ci and non-ci tables in the context of a single transaction. You can read more at https://docs.gitlab.com/ee/development/database/multiple_databases.html#removing-cross-database-transactions .

This code is apparently not used and not needed anymore as we don't allow people to install runners this way anymore. For now I decided to just focus on removing the small amount of code that was causing problems but it seems there could be a deeper rabbit hole here of removing lots of unused code but I decided not to tackle that all at once.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #346315 (closed)

Merge request reports