Mark ci_templates metrics as removed
What does this MR do and why?
Describe in detail what your merge request does and why.
Related with https://gitlab.com/gitlab-org/gitlab/-/issues/338029
These metrics were renamed or removed in 223a3c66
We should mark them as removed in definitions so they won't appear in service ping when using instrumentation classes.
These were removed when using usage_data.rb and it is not affecting Service ping payload in any way
Close #341811 (closed)
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Generate the Service ping redis HLL metrics using usage_data.rb
Gitlab::UsageData.redis_hll_counters
- Generate Redis HLL metrics using instrumentation classes
::Gitlab::Usage::Metric.all.select{|m| m.definition.data_source == "redis_hll"}.map(&:with_value).reduce({}, :deep_merge)
- Compare results using hash_diff
HashDiff.diff(before, after)
- There should be no difference
- The metrics marked as removed should not appear in payload generated using instrumentation classes more in payload generated using usage_data.rb
p_ci_templates_implicit_auto_devops_build_monthly
p_ci_templates_implicit_auto_devops_deploy_monthly
p_ci_templates_5_min_production_app_monthly
p_ci_templates_aws_cf_deploy_ec2_monthly
p_ci_templates_auto_devops_build_monthly
p_ci_templates_auto_devops_deploy_monthly
p_ci_templates_auto_devops_deploy_latest_monthly
p_ci_templates_implicit_auto_devops_deploy_latest_monthly
p_ci_templates_implicit_auto_devops_build_weekly
p_ci_templates_implicit_auto_devops_deploy_weekly
p_ci_templates_5_min_production_app_weekly
p_ci_templates_aws_cf_deploy_ec2_weekly
p_ci_templates_auto_devops_deploy_weekly
p_ci_templates_auto_devops_deploy_latest_weekly
p_ci_templates_implicit_auto_devops_deploy_latest_weekly
p_ci_templates_auto_devops_build_weekly
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Alina Mihaila