Skip to content

Handle abusive search parameters

John Mason requested to merge handle-abusive-search-params into master

What does this MR do and why?

We currently get all sorts of nasty parameters that appear to have malicious intent. These types of abusive search parameters cause errors.

This was discovered by looking through exceptions on Global Search here.

If parameters like these are detected, the SearchController will give an OK response but won't do any real work. Also, this will log these types of events so we can have faster response times to block potentially abusive users that do these types of searches.

Screenshots or screen recordings

Exhibit A image
Exhibit B image
Exhibit C image
Exhibit D image
Exhibit E image

How to set up and validate locally

Run test suite on search_controller_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by John Mason

Merge request reports