Skip to content

Hide Auto Approve Pending Users Modal Behind Feature Flag

Jason Goodman requested to merge hide-user-cap-increase-confirmation-modal into master

What does this MR do and why?

!72805 (merged) introduced a modal dialog to inform admins that pending users will automatically be approved when the user cap is increased.

We pushed this feature to a later iteration here: https://gitlab.com/gitlab-org/gitlab/-/issues/334381#note_735029103.

This MR adds a new feature flag to hide the modal independently of the :saas_user_caps feature flag.

This way, we can enable the :saas_user_caps feature flag, and this modal will remain hidden. We can use the newly introduced :saas_user_caps_auto_approve_pending_users_on_cap_increase feature flag later to roll out the auto approve pending users feature.

Issue: #330028 (closed)

Screen recordings

Feature Flag Off

The form saves right away with no modal.

Screen_Recording_2021-11-18_at_3.43.33_PM

Feature Flag On

The modal appears first.

Screen_Recording_2021-11-18_at_3.46.09_PM

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jason Goodman

Merge request reports