Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 36,994
    • Issues 36,994
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1,447
    • Merge requests 1,447
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !7474

Merged
Created Sep 24, 2018 by Gabriel Mazetto@brodock🔶Maintainer6 of 6 tasks completed6/6 tasks

Resolve "Geo::RepositoryVerification::Secondary::ShardWorker lease key is not namespaced by shard name"

  • Overview 11
  • Commits 2
  • Pipelines 2
  • Changes 5

What does this MR do?

Adds a namespace with the shard name for the lease key in the repository verification job for a secondary node.

With a namespaced lease key, multiple jobs can run at the same time (one for each unique shard).

This fix the previous behavior where only the first job was executing, failing for all the other shards.

What are the relevant issue numbers?

#7722 (closed) gitlab-org/gitlab-ee#6980

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Conforms to the code review guidelines
  • Conforms to the merge request performance guidelines
  • Conforms to the style guides
  • EE specific content should be in the top level /ee folder

Closes #7722 (closed)

Edited Sep 25, 2018 by Gabriel Mazetto
Assignee
Assign to
Reviewer
Request review from
11.3
Milestone
11.3 (Past due)
Assign milestone
Time tracking
Source branch: 7722-geo-repository-verification-lease-key