Skip to content

Allow SidekiqExporter to accept an optional port argument

Roy Zwambag requested to merge 345886-sidekiq-exporter-port into master

What does this MR do and why?

This MR allows us to run SidekiqExporter on a custom port. This argument is optional and is currently not used anywhere. This MR is made in preparation of #345887 (closed) . We created a PoC !73049 (closed) where we found that we will need to run the metrics exporter server on a different port (so we can run both the workers and the metrics exporter server).

Actually using the port parameter will come in a future MR.

How to set up and validate locally

To validate that it still works:

  1. Run bin/background_jobs (GDK does this when you run gdk start)
  2. curl localhost:<metrics_port>/metrics -- it should serve metrics. Default metrics port is 3807

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #345886 (closed)

Merge request reports