Skip to content

Fix the project level NPM QA spec

David Fernandez requested to merge 345521-fix-npm-project-level-spec into master

🌴 Context

In !74399 (merged), all package QA specs were updated to use a unique package name. This was done to avoid flaky situations where duplicated packages are uploaded. For some package formats (namely NPM), this is not allowed.

In that MR, we also unquarantined the NPM project level QA spec, thinking that the unique package name would fix it.

Unfortunately, we missed that the project level QA spec was still using a fixed name in the metadata file (package.json). In other words, that spec was still using a fix/static package name instead of the dynamic one.

This caused a QA incident and the spec was quarantined again.

This MR aims to fix the NPM project level spec for good.

The issue tracking the efforts of using unique package names is: #345521 (closed)

🔭 What does this MR do and why?

  • Unquarantine the NPM project level QA spec
  • Update it so that the dynamic package name is used in those locations where the package name is needed (for example, in the package.json content)

📺 Screenshots or screen recordings

n / a

🛠 How to set up and validate locally

  1. Follow https://about.gitlab.com/handbook/engineering/development/ops/package/quality/#how-to-run-them-locally
  2. Run the maven scenario: 
    $ WEBDRIVER_HEADLESS=false bundle exec bin/qa Test::Instance::All http://172.16.123.1:8000 -- qa/specs/features/browser_ui/5_package/package_registry/npm/npm_project_level_spec.rb --tag orchestrated --tag packages

🏁 MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by David Fernandez

Merge request reports