Skip to content

Alter masked_page_url to accept group and project arguments instead of calling the controller methods

Niko Belokolodov requested to merge 345510-fix-saml-sso-redirects-for-pseudonymized-urls-for-snowplow-tracking-2 into master

What does this MR do and why?

To improve maintainability we refactor masked_page_url method to accept arguments explicitly.

How to set up and validate locally

  1. Set up SAML SSO for a group (https://gitlab.com/gitlab-org/gitlab-development-kit/blob/main/doc/howto/saml.md)
  2. Try to get access to the group using SSO. The link would be https://<server_url>:<port?/groups/<group_name>/-/saml/sso. Its available on /groups/<group_name>/-/saml page
  3. The login page should be displayed. Login attempt should be successful.

loginwithsso

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #345510 (closed)

Edited by Niko Belokolodov

Merge request reports