Change default Namespace type from nil to User

What does this MR do and why?

Change default for type column for namespaces Namespaces in DB. Change default to 'User'.

DB migrate output

up

$ bundle exec rails db:migrate:up VERSION=20211116091751
== 20211116091751 ChangeNamespaceTypeDefaultToUser: migrating =================
-- transaction_open?()
   -> 0.0000s
-- change_column_default(:namespaces, :type, "User")
   -> 0.0089s
== 20211116091751 ChangeNamespaceTypeDefaultToUser: migrated (0.0246s) ========

down

$ bundle exec rails db:migrate:down VERSION=20211116091751
== 20211116091751 ChangeNamespaceTypeDefaultToUser: reverting =================
-- transaction_open?()
   -> 0.0000s
-- change_column_default(:namespaces, :type, nil)
   -> 0.0161s
== 20211116091751 ChangeNamespaceTypeDefaultToUser: reverted (0.0315s) ========

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

BLOCKED BY !74152 (merged) and !73495 (merged)

(No longer blocked as we've changed what this MR does - it only sets the default namespace type to User instead of directly migrating any data)

Related to #345105 (closed)

changed milestone to %14.5

added auto updated automation:ml automation:ml wrong devopsmanage sectiondev + 1 deleted label

assigned to @cablett

changed target branch from master to 341447-cablett-namespace-factory

added 2 commits

• 4c7af3d5 - 1 commit from branch 341447-cablett-namespace-factory
• 2762cc44 - Prohibit nil type Namespaces in DB

Compare with previous version

added database databasereview pending labels

	1 Warning
	Please add a merge request type to this merge request.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Eugenia Grieff (@egrieff) (UTC+0, 13 hours behind @cablett)	Sincheol (David) Kim (@dskim_gitlab) (UTC+10.5, 2.5 hours behind @cablett)
database	Maxime Orefice (@morefice) (UTC+1, 12 hours behind @cablett)	Krasimir Angelov (@krasio) (UTC+13, same timezone as @cablett)
~migration	No reviewer available	No maintainer available

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

cc @digitalmoksha @acroitor @jprovaznik for

Does this sound good for after !74152 (merged) is merged? (I can't set a dependency since it's also blocking... I think)

changed the description

added 1 commit

• 96660509 - Prohibit nil type Namespaces in DB

Compare with previous version

added 1 commit

• 2ced9b63 - Prohibit nil type Namespaces in DB

Compare with previous version

Would this be Changelog: changed or Changelog: other?

added 1 commit

• c9ddad93 - Prohibit nil type Namespaces in DB

Compare with previous version

@acroitor would you please perform domain/DB review?

requested review from @acroitor

added 1 commit

• d116dcda - Prohibit nil type Namespaces in DB

Compare with previous version

added 1 commit

• 4ddabaed - Prohibit nil type Namespaces in DB

Compare with previous version