Skip to content

Draft: Remove suggest .gitlab-ci.yml feature

Eugie Limpin requested to merge remove-suggest-gitlab-ci-yml-feature into master

What does this MR do and why?

This MR removes code that implements "Suggest .gitlab-ci.yml" feature.

The feature was introduced in gitlab-org/growth&14 (closed) and can be seen in action in the following GIF:

suggest_gitlab_ci_yml

Feature flow

  1. User visits MR without pipeline
  2. User sees Suggest Pipeline banner
  3. User clicks on Suggest Pipeline banner CTA
  4. User is taken to File Editor and shown step-by-step walkthrough (popovers) to
    1. Select a template
    2. Commit the file
  5. User is taken to the newly created .gitlab-ci.yml file and shown a celebratory modal

This MR removes code for steps 4 and 5 above.

Why is this feature being removed?

In !73514 (merged) the Suggest Pipeline banner was updated to take the user to the Pipeline Editor (instead of the File Editor–step 4 of Feature flow above) where they are shown a pre-selected template for a new .gitlab-ci.yml that they can commit.

With that update, there is no longer any code path that takes the user to see the "Suggest .gitlab-ci.yml" feature.

As well, in !74063 (merged) a new walkthrough was added to the Pipeline Editor page as an experiment replacing steps 4.1 and 4.2 (Feature flow above).

Removed tracked events

This MR removes tracking code for events with the following labels:

  • suggest_gitlab_ci_yml
  • suggest_commit_first_project_gitlab_ci_yml
  • suggest_gitlab_ci_yml_commit_changes
  • congratulate_first_pipeline

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eugie Limpin

Merge request reports