Skip to content

Hide details for invited members in seats usage

What does this MR do and why?

It hides the details toggle icon for rows where the user membership type is group_invite or project_invite, since the details in these two cases would be empty.

Screenshots or screen recordings

before after
Screen_Shot_2021-11-11_at_1.22.39_PM Screen_Shot_2021-11-11_at_1.23.35_PM

How to set up and validate locally

Thanks to @amandarueda for providing the stepped details.

  1. Create root group A
    1. Add 2 members
    2. Create a project
    3. Add a paid subscription to group A
  2. Create (using the same user) unrelated root group B
    1. Add 2 members (must be different from members added to group A)
  3. View group A's seat usage page - should display the 2 members you added to group A
  4. Invite group B to group A's project
  5. View group A's billing page - should list 4 billable members
  6. View group A's seat usage page - should display the 2 members you added to group A and 2 members you added to group B
  7. The members associated with group B should not have the details icon visible

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #334050 (closed)

Edited by Ammar Alakkad

Merge request reports