Skip to content

Remove license compliance feature flag reference

What does this MR do and why?

After the license_compliance_denies_mr feature flag was enabled, it was removed via !43577 (merged). That MR didn’t remove all references because the feature flag is named licenseComplianceDeniesMr in Vue. This MR removes the remaining feature flag references to enable two UI changes that were part of the feature flag.

This also fixes a wrong GitLab UI util class (found in !60841 (merged)) in the policies table.

Screenshots or screen recordings

Where Before After
Policies (non-admin) image image
Policy tooltip n/a image
Adding a license policy (admin) image image

How to set up and validate locally

Prerequisite

  1. Create a project
  2. Set up license compliance via CI with at least one detected license

Policies (non-admin)

  1. Switch to a non-admin user, who has access to the project (e.g. Developer)
  2. Go to Security & Compliance -> License Compliance
  3. Click on the Policies tab
  4. See the question mark

Adding a license policy (admin)

  1. Switch to an admin user, who has access to the project (e.g. Maintainer/Owner)
  2. Go to Security & Compliance -> License Compliance
  3. Click on the Policies tab
  4. Click on Add license policy
  5. See the descriptions of the Allow and Deny policy options

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Kev

Merge request reports

Loading