Skip to content

[Feature Flag] jupyter_clean_diffs - Clean up log events

Eduardo Bonet requested to merge 344904-feature-flag-jupyter_clean_diffs-feature-flag-cleanup into master

What does this MR do and why?

We added some logs to help debug a feature, and we are not removing most of them. One log is left for telemetry (IPYNB_DIFF_GENERATED/IPYNB_DIFF_NIL)

This MR doesn't have a changelog as it is part of a feature being added at this release, and the changelog is included in !71477 (merged)

Screenshots or screen recordings

No screenshots

How to set up and validate locally

  1. Create a mirror of https://gitlab.com/gitlab-org/incubation-engineering/mlops/ipynb-test-projects/diff-sample into your gdk instance
  2. tail the logs: 
    tail -f path/to/gitlab/log/application.log
  3. Open the commit http://gdk.test:3000/<my-repo>/-/commit/542d42a0196e2e94a0d5793acdee5ba997ab12bf
  4. Verify on the logs that the following event is generated: 2021-11-09T16:00:27.008Z: {:message=>"IPYNB_DIFF_GENERATED"}
  5. Verify that no event IPYNBDIFF_BLOB_GENERATED is generated

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #344904 (closed)

Edited by Eduardo Bonet

Merge request reports