Skip to content

Draft: Fix bin/web script error

Dmitry Gruzd requested to merge fix-bin-web-script into master

What does this MR do and why?

This MR fixes

$ bin/web start_foreground
{"timestamp":"2021-11-09T11:28:09.292Z","pid":65234,"message":"Puma starting in cluster mode..."}
{"timestamp":"2021-11-09T11:28:09.292Z","pid":65234,"message":"* Puma version: 5.3.2 (ruby 2.7.4-p191) (\"Sweetnighter\")"}
{"timestamp":"2021-11-09T11:28:09.292Z","pid":65234,"message":"*  Min threads: 1"}
{"timestamp":"2021-11-09T11:28:09.292Z","pid":65234,"message":"*  Max threads: 4"}
{"timestamp":"2021-11-09T11:28:09.292Z","pid":65234,"message":"*  Environment: "}
{"timestamp":"2021-11-09T11:28:09.292Z","pid":65234,"message":"*   Master PID: 65234"}
{"timestamp":"2021-11-09T11:28:09.292Z","pid":65234,"message":"*      Workers: 2"}
{"timestamp":"2021-11-09T11:28:09.292Z","pid":65234,"message":"*     Restarts: (✔) hot (✖) phased"}
{"timestamp":"2021-11-09T11:28:09.292Z","pid":65234,"message":"* Preloading application"}
2021-11-09 14:28:09 +0300 {"timestamp":"2021-11-09T11:28:09.292Z","pid":65234,"message":"ERROR: No application configured, nothing to run"}

This issue appeared after !73512 (merged) was merged because we started passing the entire argument list to the server command. For example:

exec bundle exec puma --config "/home/dgruzd/projects/gdk-ee/gitlab/config/puma.rb" --environment "development" "start_foreground"

instead of

exec bundle exec puma --config "/home/dgruzd/projects/gdk-ee/gitlab/config/puma.rb" --environment "development"

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dmitry Gruzd

Merge request reports