Skip to content

Remove `toExist` jest matcher

Peter Hegman requested to merge peterhegman/remove-toExist-jest-matcher into master

What does this MR do and why?

Removes the toExist jest matcher that was available because we are using the custom-jquery-matchers package. This matcher is confusing because VTU has the exists method that checks for the existence of an element. During a recent review I noticed that toExist was being used in a Vue component test instead of exists and this was causing a false positive test. After looking through the rest of the instances of toExist I noticed there are a number of other false positives.

Since we are trying to move away from jQuery and this matcher has caused some confusion I think it is reasonable to remove it.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports