Skip to content

Update admin deploy keys table to comply with Pajamas design system

Peter Hegman requested to merge 334874-convert-table-in-admin-applications-and-admin-deploy-keys-table-to-pajamas-css into master

What does this MR do and why?

Related to #334874 (closed)

Updates CSS classes on table in Admin -> Deploy keys to comply with Pajamas design system. This is the MVC but in the future we will convert this table to Vue (#344927 (closed))

Screenshots or screen recordings

Desktop

Before After
Screen_Shot_2021-11-05_at_12.06.57_PM Screen_Shot_2021-11-05_at_11.59.03_AM

Mobile

Before After
Screen_Shot_2021-11-05_at_12.07.59_PM Screen_Shot_2021-11-05_at_12.05.58_PM

How to set up and validate locally

  1. Navigate to /admin/deploy_keys and create two deploy tokens. You can use https://8gwifi.org/sshfunctions.jsp to quickly generate a dummy public key.
  2. Navigate to a project and then Settings -> Repository -> Deploy keys
  3. Click the Publicly accessible deploy keys tab and click Enable next to each deploy key.
  4. Navigate to the Enabled deploy keys tab. Click Edit next to each deploy key and check the Grant write permissions to this key checkbox
  5. Navigate to /admin/deploy_keys

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports